-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup_args and run meson setup
explictly
#1223
Conversation
The failed test seems to be caused by issues with the CI rather than this PR. It's a bit of a mixed bag, so I have copied what seems to be the main error for each failing job. Buildifier
Examples (spawn_strategy=standalone)
Examples on MacOS
Flags on MacOS
|
@jheaff1 do you have time to review the changes in this PR? |
Place dictionary items in lexicographical order
Fixed in c7bcf7d |
Looks like the other macOS failures are due to the runners upgrading the version of XCode installed.. The fix for this likely needs to come in the apple toolchain. |
I think this is ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without really knowing meson, this seems a reasonable change and CI is now all green so I'm happy with this.
Co-authored-by: James Sharpe <[email protected]>
Resolves #1170