Skip to content

Commit

Permalink
Pass '-undefined error' non sysroot ldflag on macOS (#894)
Browse files Browse the repository at this point in the history
  • Loading branch information
uhthomas authored Apr 19, 2022
1 parent e7eebef commit cac4699
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions foreign_cc/built_tools/make_build.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ def _make_tool_impl(ctx):
if absolute_ar == "libtool" or absolute_ar.endswith("/libtool"):
arflags.append("-o")

if os_name(ctx) == "macos":
non_sysroot_ldflags += ["-undefined", "error"]

env.update({
"AR": absolute_ar,
"ARFLAGS": _join_flags_list(ctx.workspace_name, arflags),
Expand Down

0 comments on commit cac4699

Please sign in to comment.