Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden files being copied to the wrong directory #404

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

cgrindel
Copy link
Member

@cgrindel cgrindel commented Nov 28, 2024

The initial copy will copy over hidden files in sub-directories. The copy find logic for hidden files was looking through the entire tree. We really just want to copy the hidden files in the top-level directory.

Also, adjusted the glob pattern for the "non-hidden" file copy per a shellcheck warning.

@cgrindel cgrindel self-assigned this Nov 28, 2024
@cgrindel cgrindel changed the title fix: force copy hidden files when creating scratch directories fix: hidden files being copied to the wrong directory Nov 28, 2024
@cgrindel cgrindel requested a review from katre November 28, 2024 21:09
@cgrindel cgrindel marked this pull request as ready for review November 28, 2024 21:09
@katre katre merged commit 0d844b3 into main Dec 2, 2024
5 checks passed
@katre katre deleted the permission_error branch December 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants