Add a bazel_feature to gate the grep_includes parameter
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
requested changes
Jul 31, 2023
meteorcloudy
approved these changes
Jul 31, 2023
|
@fmeum @alexeagle we probably need a new release for rules_rust. |
|
I have never done releases in this repo, do I need to do more than push a tag? |
|
Just push a tag to this repo when you want a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grep_includesparameter has been made optional incc_commonAPIs as of Bazel 6.3 (e.g. in bazelbuild/bazel#18823). This feature allows for rulesets to support versions < 6.3, where thegrep_includesparameter is mandatory, as well as to prepare for future Bazel releases where thegrep_includesparameter will not exist.