Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update jq docs to show correct escaping #983

Merged
merged 1 commit into from
Nov 30, 2024
Merged

docs: Update jq docs to show correct escaping #983

merged 1 commit into from
Nov 30, 2024
+2 −2

Conversation

ChrisChinchilla
Copy link
Contributor

As seen here:

bazel-lib/lib/jq.bzl

Line 87 in 31e6c76

filter = "{ deps: split(\"\\n\") | map(select(. | length > 0)) }",

The docs show the incorrect escaping sequence.

@alexeagle
Copy link
Collaborator

Per the failing test, this needs to be updated in jq.bzl as well. Line 1 of the file you've edited is a hint that it's generated (would be nice if it said where it was generated from)

@ChrisChinchilla
Copy link
Contributor Author

@alexeagle OK, this involved so much escaping to get them to show correctly in the generated MD, I now wonder if it makes the original file useful anymore? Also, can you check that espcaing is still indeed correct?

@gregmagolan gregmagolan merged commit 5853e2e into bazel-contrib:main Nov 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisChinchilla @alexeagle @gregmagolan