fix: go back to bsdtar-prebuilt 3.7.4 but with a release with a working windows binary #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng windows binary
jbedard
approved these changes
Oct 19, 2024
|
Is there any way to test this here in bazel-lib? |
I'm not sure what it is about those particular tests in silo that causes tar extract to fail. Would be good to track it down and make a minimal repro test in the future. For now I tested this change with a patch in silo and verified it fixes the issue. |
|
FYSA @alexeagle @dzbarsky |
|
Isn't this just going to break again the next time we upgrade libarchive? |
Likely yes. We have no idea why it was broken on silo. We need a repro outside of silo for this so we can figure out why it was built wrong so we can fix it without having to test in silo. |
jbedard
pushed a commit
to aspect-build/aspect-cli
that referenced
this pull request
Oct 23, 2024
Picks up bazel-contrib/bazel-lib#969 that fixes tar extract regression. ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 90aab309d171e7c901f4e1cfd19803aa8c34ee6e
jbedard
pushed a commit
to aspect-build/aspect-cli
that referenced
this pull request
Oct 24, 2024
Picks up bazel-contrib/bazel-lib#969 that fixes tar extract regression. ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 90aab309d171e7c901f4e1cfd19803aa8c34ee6e
jbedard
pushed a commit
to aspect-build/aspect-cli
that referenced
this pull request
Oct 24, 2024
Picks up bazel-contrib/bazel-lib#969 that fixes tar extract regression. ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 90aab309d171e7c901f4e1cfd19803aa8c34ee6e
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Nov 24, 2024
Previous tar issues were resolved in bazel-contrib/bazel-lib#969.
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Nov 24, 2024
- Previous tar issues were resolved in bazel-contrib/bazel-lib#969. - Drop outDir in types tsconfig to unblock rules_ts update
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Nov 24, 2024
- Previous tar issues were resolved in bazel-contrib/bazel-lib#969. - Drop outDir in types tsconfig to unblock rules_ts update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tar extract regression in 2.8.0 due to bump to bsdtar-prebuilt 3.7.5 in #940.
bsdtar-prebuilt 3.7.5 (which depends on libarchive 3.7.5) has a regression that showed up in testing of our internal silo repo when attempting to bump bazel-lib. previously working tests with tar extracts starting to fail with
invalid tar header. I also tested with a test bsdtar-prebuilt 3.7.7 release, built with libarchive 3.7.7, to see if there was a regression in libarchive 3.7.5 (one such regression was mentioned in https://github.com/libarchive/libarchive/releases/tag/v3.7.6) but also hit the same failure. Another possibility is BCR patches for libarchive 3.7.5 that were copied over from 3.7.4 may not be correct for 3.7.5.In any case, to get back to a working version of tar in bazel-lib, this change goes back to safety by switching to a bsdtar-prebuilt 3.7.4 release with a working Windows binary: https://github.com/aspect-build/bsdtar-prebuilt/releases/tag/v3.7.4-4.