Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecated expand_locations which is just pass-through to ctx.expand_location() #910

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Aug 19, 2024

expand_locations is marked DEPRECATED since it now just calls ctx.expand_location(input, targets = targets). There was once a custom implementation but that was removed a while ago.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

expand_locations is marked DEPRECATED since it now just calls ctx.expand_location(input, targets = targets). There was once a custom implementation but that was removed a while ago.

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Aug 19, 2024

Test

All tests were cache hits

220 tests (100.0%) were fully cached saving 29s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 750ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 742ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the deprecate_expand_locations branch from 282766f to 2c6c07a Compare August 19, 2024 19:19
@gregmagolan gregmagolan merged commit eb55a3c into main Aug 19, 2024
35 checks passed
@gregmagolan gregmagolan deleted the deprecate_expand_locations branch August 19, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants