-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly split quoted args #909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
handle_quoted_strings_in_args_split
branch
2 times, most recently
from
August 19, 2024 18:27
68fa390
to
8ae50b8
Compare
jbedard
reviewed
Aug 19, 2024
jbedard
reviewed
Aug 19, 2024
gregmagolan
force-pushed
the
handle_quoted_strings_in_args_split
branch
from
August 19, 2024 18:54
8ae50b8
to
c8cb6a5
Compare
jbedard
reviewed
Aug 19, 2024
jbedard
reviewed
Aug 19, 2024
gregmagolan
force-pushed
the
handle_quoted_strings_in_args_split
branch
3 times, most recently
from
August 19, 2024 19:39
3fa4724
to
fd62c80
Compare
gregmagolan
force-pushed
the
handle_quoted_strings_in_args_split
branch
from
August 19, 2024 19:42
fd62c80
to
cdeead9
Compare
jbedard
reviewed
Aug 19, 2024
jbedard
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #891 (requested by Bazel Open Source Support customer).
Changes are visible to end-users: yes
New function
split_args
is added to the public API ofstrings.bzl
.This fix touches a number of different rules:
jq
rule expansions now include make vars and rule fixed to single quote args that contain spacesexpand_template
optimized to not to bother with pointless.split(" ")
followed by" ".join()
bats_test
optimized to not to bother with pointless.split(" ")
followed by" ".join()
params_file
rule fixed to correctly split args on quotesrun_binary
rule fixed to correctly split args on quotesTest plan
Unit tests added for the new
split_args
function that handles parsing args and splitting them taking into account single quotes, double quotes and escapes.