Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add platform_transition_test #770

Merged

Conversation

lamcw
Copy link
Contributor

@lamcw lamcw commented Feb 28, 2024

Type of change

New feature or functionality (change which adds functionality)

Adding a test equiv. for platform_transition_binary. We find this very useful when we need to run tests targeting multiple platforms.

Test plan

New test cases added

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Thomas Lam <[email protected]>
@lamcw lamcw marked this pull request as ready for review February 28, 2024 02:38
@gregmagolan gregmagolan changed the title Supports platform transition test feat: add platform_transition_test Apr 3, 2024
@gregmagolan gregmagolan merged commit faaada2 into bazel-contrib:main Apr 3, 2024
1 check passed
@gregmagolan
Copy link
Collaborator

Thank you for the addition @lamcw !

@gregmagolan
Copy link
Collaborator

Including this in 2.7.0

@lamcw lamcw deleted the supports-platform-transition-test branch April 3, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants