[Bug]: copy_to_directory_bin_action() creates an empty directory when run in an external workspace.

[dgp1130]

What happened?

More context: https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1676010753876439

npm_package() from @aspect_rules_js doesn't include sources from its own workspace when built in an external workspace. Instead, you get an empty directory (more context). It seems that the include_external_repositories filter of copy_to_directory is a little overzealous and automatically includes sources from the __main__ workspace, not the workspace containing the target. I think the correct behavior here is to automatically include any files in the same workspace as the npm_package() target, and I think that also applies to the underlying copy_to_directory_bin_action().

I think the right fix is to just make copy_to_directory_bin_action() add a --workspace_name flag containing the name of the workspace for the current target and pass that into the copy_to_directory tool. Then the tool should always include files within that workspace regardless of include_external_repositories (after applying other filters ofc).

I have a failing test case in dgp1130@33e3ed9, but haven't started on a proper fix yet.

Version

Reproducible in latest version of @aspect_bazel_lib (1.24.2).

How to reproduce

# my_wksp/BUILD.bazel

npm_package(name = "pkg", srcs = ["file.txt"])

Then link that from another workspace:

# my_other_wksp/WORKSPACE.bazel

local_repository(
    name = "my_wksp",
    path = "../my_wksp",
)

Then build:

(cd my_other_wksp/ && bazel build @my_wksp//:pkg)

It will output an empty directory.

Any other information?

My current workaround is to add include_external_repositories = ["my_wksp"] to npm_package(), but it's not ideal and requires that any downstream workspaces refer to this package's workspace as @my_wksp when they should be free to choose any name.

Fund our work

• Sponsor our open source work by donating a bug bounty