runner: propagate 'testonly' property to sh_binary #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjjw
force-pushed
the
pjjw/pass-testonly-to-runner
branch
from
4ebe79b to
dda3c46
Compare
fmeum
approved these changes
Jan 4, 2025
|
Let me know when this is ready |
|
@fmeum good to go, thanks! |
this makes sure that if testonly is set in the macro, it's propagated both to the runner _and_ the wrapper sh_binary. as is, setting 'testonly' in the macro will result in an unbuildable sh_binary if there are testonly dependencies. why this is needed: slightly esoteric, but our build process currently uses the gazelle plugin from contrib_rules_jvm. for uninteresting reasons, this depends on the output of another tool, which itself needs to process testonly dependencies.
fmeum
force-pushed
the
pjjw/pass-testonly-to-runner
branch
from
dda3c46 to
12cc6fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes sure that if testonly is set in the macro, it's propagated
both to the runner and the wrapper sh_binary. as is, setting
'testonly' in the macro will result in an unbuildable sh_binary if there
are testonly dependencies.
why this is needed: slightly esoteric, but our build process currently
uses the gazelle plugin from contrib_rules_jvm. for uninteresting
reasons, this depends on the output of another tool, which itself needs
to process testonly dependencies.
it's a silly little patch we've been carrying for a while, but since currently
setting the property as is results in breakage, thought i might have a shot
at upstreaming it.