Bump rules_go & Bazel deps #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not updating to rules_go 0.50.1 quite yet as that runs into issues with nogo. Bumping the compatibility SDK is needed due to changes to `golang.org/x/tools` that require Go 1.19 (`types.Func.Origin()`).
fmeum
force-pushed
the
update-deps
branch
2 times, most recently
from
49b2c4d to
a82e8b9
Compare
fmeum
force-pushed
the
update-deps
branch
4 times, most recently
from
3b1fa00 to
21cdc73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Deps
What package or component does this PR mostly affect?
all
What does this PR do? Why is it needed?
Bumping the compatibility SDK is needed due to changes to
golang.org/x/toolsthat require Go 1.19 (types.Func.Origin()) and, temporarily, due to non-hermeticity in rules_go'sGoToolchainBinaryBuild.Which issues(s) does this PR fix?
Fixes #
Other notes for review