Don't call dict.pop() with named arguments #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though Bazel is fine with the code as is, Go Starlark's dict.pop() only takes positional arguments. My assumption is that this is correct, because Python does so as well.
fmeum
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
all
What does this PR do? Why is it needed?
I'm doing some experiments, where I'm trying to parse/analyze some existing Bazel rules using Go Starlark. This seems to be mostly successful, though I am noticing some small breakages.
Which issues(s) does this PR fix?
It fixes an issue where dict.pop() is called with named arguments in a couple of places, even though it's only supposed to be called with positional arguments.
Other notes for review