refactor: remove reference to rule.Rule in mapResolver interface #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
changed the title
fmeum
reviewed
Aug 19, 2024
jbedard
force-pushed
the
interface-no-rules
branch
from
46ece3a to
e7e3f55
Compare
fmeum
approved these changes
Aug 19, 2024
tyler-french
added a commit
to tyler-french/bazel-gazelle
that referenced
this pull request
Aug 28, 2024
…ace (bazel-contrib#1873)" This reverts commit 3ddf7ee.
tyler-french
added a commit
to tyler-french/bazel-gazelle
that referenced
this pull request
Aug 28, 2024
…ace (bazel-contrib#1873)" This reverts commit 3ddf7ee.
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Sep 29, 2024
##### [`vv0.39.0](https://github.com/bazelbuild/bazel-gazelle/releases/tag/v0.39.0) #### What's Changed - Add QNX and OSX to known platforms by [@hofbi](https://github.com/hofbi) in bazel-contrib/bazel-gazelle#1853 - Allow `+` in repo names by [@fmeum](https://github.com/fmeum) in bazel-contrib/bazel-gazelle#1856 - go_repository_cache: set GOTOOLCHAIN to 'local' by [@lbcjbb](https://github.com/lbcjbb) in bazel-contrib/bazel-gazelle#1859 - Fix Issue [#1855](bazel-contrib/bazel-gazelle#1855): "All Bazel commands fail when changing a Go dependency when using Bzlmod extension" by [@Buzz-Lightyear](https://github.com/Buzz-Lightyear) in bazel-contrib/bazel-gazelle#1861 - Add default directives for github.com/containerd by [@mering](https://github.com/mering) in bazel-contrib/bazel-gazelle#1866 - Add gazelle-overrides for argo, grpcgateway by [@udaya2899](https://github.com/udaya2899) in bazel-contrib/bazel-gazelle#1867 - refactor: remove file reference from ruleRecord by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1869 - refactor: compute transitive embeds during indexing by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1868 - refactor: compute labelMap when indexing by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1872 - refactor: remove reference to rule.Rule in mapResolver interface by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1873 - refactor: ensure rule index not modified after indexing by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1877 - docs: fix incorrect gazelle_generation_test param name by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1876 - refactor: embed gazelle generation_test_binary in gazelle_generation_test instead of recompiling by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1875 - refactor: make ruleRecord serializable by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1878 - Add package metadata to `go_repository`s by [@fmeum](https://github.com/fmeum) in bazel-contrib/bazel-gazelle#1852 - refactor: process KindMap even when not indexing by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1882 - refactor: move walk util methods into struct by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1881 - refactor: add nil assignments to verify interface implementations by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1883 - perf: preload .bazelignore before configure, do not use globs by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1886 - refactor: remove nested walk function literal by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1884 - Preserve canonical labels as such by [@fmeum](https://github.com/fmeum) in bazel-contrib/bazel-gazelle#1863 - perf: check if directory in .bazelignore before readdir by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1890 - revert [#1873](bazel-contrib/bazel-gazelle#1873) by [@tyler-french](https://github.com/tyler-french) in bazel-contrib/bazel-gazelle#1897 - rename `main()` entrypoints to `main.go` by [@tyler-french](https://github.com/tyler-french) in bazel-contrib/bazel-gazelle#1901 - Support timeout and size in gazelle_test by [@rockwotj](https://github.com/rockwotj) in bazel-contrib/bazel-gazelle#1909 - feat: include package URL in package_info by [@alexeagle](https://github.com/alexeagle) in bazel-contrib/bazel-gazelle#1917 - perf: Improve rule.Kind by [@dzbarsky](https://github.com/dzbarsky) in bazel-contrib/bazel-gazelle#1919 - Fix patch file creation using Gazelle in diff mode by [@alandonham](https://github.com/alandonham) in bazel-contrib/bazel-gazelle#1915 - perf: Improve merger.Mergefile by [@dzbarsky](https://github.com/dzbarsky) in bazel-contrib/bazel-gazelle#1920 - test: add bazelignore test by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1912 - perf: walk workspace directories in parallel by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1893 - refactor: reduce path.join while walking repo by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1913 - chore: upgrade go mod dependencies by [@jbedard](https://github.com/jbedard) in bazel-contrib/bazel-gazelle#1911 - prepare gazelle release 0.39 by [@tyler-french](https://github.com/tyler-french) in bazel-contrib/bazel-gazelle#1925 - Add gazelle overrides to enable building rclone by [@dmcardle](https://github.com/dmcardle) in bazel-contrib/bazel-gazelle#1933 #### New Contributors - [@hofbi](https://github.com/hofbi) made their first contribution in bazel-contrib/bazel-gazelle#1853 - [@Buzz-Lightyear](https://github.com/Buzz-Lightyear) made their first contribution in bazel-contrib/bazel-gazelle#1861 - [@udaya2899](https://github.com/udaya2899) made their first contribution in bazel-contrib/bazel-gazelle#1867 - [@rockwotj](https://github.com/rockwotj) made their first contribution in bazel-contrib/bazel-gazelle#1909 - [@alandonham](https://github.com/alandonham) made their first contribution in bazel-contrib/bazel-gazelle#1915 - [@dmcardle](https://github.com/dmcardle) made their first contribution in bazel-contrib/bazel-gazelle#1933 **Full Changelog**: bazel-contrib/bazel-gazelle@v0.38.0...v0.39.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What package or component does this PR mostly affect?
all
What does this PR do? Why is it needed?
Ensuring all fields in
ruleRecordare primitive or easily serializable.