Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bzlmod): allow default_gazelle_attributes for go_deps extension #1716

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Jan 8, 2024

This PR creates a new tag class default_gazelle_attributes which allow the root module to provide default values for the gazelle attributes used to create the go_deps repos.

This includes the attributes: "build_file_generation", "build_extra_args", and "directives".

Default attributes will be applied to an attribute only if there is no gazelle_override value.

If default_gazelle_attributes is provided, it will override all path-specific overrides created in internal/bzlmod/default_gazelle_overrides.bzl, so users may need to reapply these with gazelle_overrides.

If a repo has either a gazelle_override or there is a default_gazelle_attributes, the "build_file_generation" attribute will be set to "on" unless explicitly set to a different value. This is because "build_extra_args", and "directives" anticipate build file generation being enabled.

If any value is provided for attrs in a gazelle_override, it will override (and not append to) any default attributes. Users must re-add any "directives" that were in default_gazelle_attributes

Additional refactoring was done to remove duplication of the handling of these attributes.

internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
@tyler-french tyler-french changed the title feat(bzlmod): allow global_overrides for go_deps extension feat(bzlmod): allow default_gazelle_attributes for go_deps extension Jan 9, 2024
@tyler-french tyler-french marked this pull request as ready for review January 9, 2024 16:59
internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
tests/bcr/MODULE.bazel Show resolved Hide resolved
@tyler-french
Copy link
Contributor Author

@fmeum Please do not merge, I have not yet tested this at Uber

@tyler-french
Copy link
Contributor Author

@fmeum Please do not merge, I have not yet tested this at Uber

I tested this and it works as expected.

@fmeum
Copy link
Member

fmeum commented Jan 14, 2024

The one thing I'm worried about is that the new default attributes are override by the per-module defaults provided by Gazelle. This makes adding a new default more breaking. But having it the other way round would remove most of the use of the Gazelle-provided defaults.
Not sure what's best yet and this may also change as we flip global defaults.

@tyler-french
Copy link
Contributor Author

The one thing I'm worried about is that the new default attributes are override by the per-module defaults provided by Gazelle. This makes adding a new default more breaking. But having it the other way round would remove most of the use of the Gazelle-provided defaults. Not sure what's best yet and this may also change as we flip global defaults.

I agree, but I think this implementation provides the most user-friendly approach, given the following considerations:

  1. Path-specific overrides that gazelle defines should only used for dependencies required to build gazelle and/or rules_go.
  2. We document that defaults are "fallbacks", and may be overridden. Explicit gazelle_override will always override path-specific overrides and fallbacks.

Two changes that should be added in this PR (which I will add), are:

  1. Remove anything from default_gazelle_overrides.bzl that isn't explicitly needed to build rules_go and gazelle.
  2. Update documentation to include the overrides included in default_gazelle_overrides.bzl, the explicit extent of gazelle_default_attributes, and how users should use gazelle_overrides to override the small number deps in default_gazelle_overrides.bzl.

@fmeum
Copy link
Member

fmeum commented Jan 18, 2024

I still think that the way you implemented precedence is the right one: Every module with Gazelle-provided defaults works if you don't specify a default override and if you do, you explicitly give up convenience for flexibility.

I think that's fine as long as we restore the list of defaults.

internal/bzlmod/go_deps.bzl Show resolved Hide resolved
internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
internal/bzlmod/go_deps.bzl Show resolved Hide resolved
internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
tests/bcr/MODULE.bazel Outdated Show resolved Hide resolved
tests/bcr/pkg/pkg_test.go Outdated Show resolved Hide resolved
tests/bcr/pkg/pkg_test.go Outdated Show resolved Hide resolved
@fmeum
Copy link
Member

fmeum commented Feb 17, 2024

The PR description is not up-to-date anymore, it still describes the previous precedence rule.

@tyler-french
Copy link
Contributor Author

The PR description is not up-to-date anymore, it still describes the previous precedence rule.

Good point, updated.

internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
@fmeum fmeum enabled auto-merge (squash) February 21, 2024 13:05
@fmeum fmeum merged commit d5ac63c into bazel-contrib:master Feb 21, 2024
14 of 15 checks passed
jeromep-stripe pushed a commit to jeromep-stripe/bazel-gazelle that referenced this pull request Mar 22, 2024
…ion (bazel-contrib#1716)

* allow global overrides

* Update internal/bzlmod/go_deps.bzl

---------

Co-authored-by: Fabian Meumertzheim <[email protected]>
renovate bot referenced this pull request in kreempuff/rules_unreal_engine Apr 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.35.0` -> `v0.36.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0)

#### What's Changed

- Test with incompatible flags by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1696](https://togithub.com/bazelbuild/bazel-gazelle/pull/1696)
- adding more default gazelle overrides by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1701](https://togithub.com/bazelbuild/bazel-gazelle/pull/1701)
- rule: add accessor for attribute comments by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700)
- rule: set update flag on Rule.AddArg by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1702](https://togithub.com/bazelbuild/bazel-gazelle/pull/1702)
- rule: rename GetAttrComments -> AttrComments by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1703](https://togithub.com/bazelbuild/bazel-gazelle/pull/1703)
- Remove some usage of deprecated ioutil by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704)
- Allow passing Gazelle binary as a file by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1706](https://togithub.com/bazelbuild/bazel-gazelle/pull/1706)
- rule: allow usage of Label struct with Rule APIs by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1705](https://togithub.com/bazelbuild/bazel-gazelle/pull/1705)
- Remove ioutil usage by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1707](https://togithub.com/bazelbuild/bazel-gazelle/pull/1707)
- doc: fix link to Swift gazelle plugin by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1708](https://togithub.com/bazelbuild/bazel-gazelle/pull/1708)
- Fix two shellcheck warnings in gazelle.bash.in by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1710](https://togithub.com/bazelbuild/bazel-gazelle/pull/1710)
- implement expression conversions via BzlExprValue interface by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1714](https://togithub.com/bazelbuild/bazel-gazelle/pull/1714)
- update documentation for 0.35 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1712](https://togithub.com/bazelbuild/bazel-gazelle/pull/1712)
- Update circl to v1.3.7 in tests by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1718](https://togithub.com/bazelbuild/bazel-gazelle/pull/1718)
- rule: make value sorting configurable (alternative implementation) by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1719](https://togithub.com/bazelbuild/bazel-gazelle/pull/1719)
- Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only
repos. by [@&#8203;Megakuul](https://togithub.com/Megakuul) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727)
- Add default gazelle override for github.com/cockroachdb/errors. by
[@&#8203;fardream](https://togithub.com/fardream) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728)
- README: fix resolve_regexp doc by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1729](https://togithub.com/bazelbuild/bazel-gazelle/pull/1729)
- feat(bzlmod): allow `default_gazelle_attributes` for `go_deps`
extension by [@&#8203;tyler-french](https://togithub.com/tyler-french)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1716](https://togithub.com/bazelbuild/bazel-gazelle/pull/1716)
- add new std_packages from go 1.22 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1740](https://togithub.com/bazelbuild/bazel-gazelle/pull/1740)
- fix: wrap generation test labels with Label() by
[@&#8203;pedrobarco](https://togithub.com/pedrobarco) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743)
- proto: Add Bzlmod support for well-known types by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1741](https://togithub.com/bazelbuild/bazel-gazelle/pull/1741)
- Test BCR with Bazel 6.5.0 and 7.0.2 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1744](https://togithub.com/bazelbuild/bazel-gazelle/pull/1744)
- Set go_naming_convention for cel-go by
[@&#8203;riking](https://togithub.com/riking) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746)
- nit: fix error message in go_repository by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750)
- Add `go_deps.config(env = ...)` as a replacement for
`gazelle_dependencies(go_env = ...)` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1748](https://togithub.com/bazelbuild/bazel-gazelle/pull/1748)
- Warn if integrity not specified for archive_override by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753)
- Use host module cache whithout build cache and verify it by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1755](https://togithub.com/bazelbuild/bazel-gazelle/pull/1755)
- Update default_gazelle_overrides.bzl by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1758](https://togithub.com/bazelbuild/bazel-gazelle/pull/1758)
- Mark `go_deps` extension as reproducible by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1761](https://togithub.com/bazelbuild/bazel-gazelle/pull/1761)
- Ignore `purego` build constraint by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767)
- Expose path to root `go.mod` to rules_go by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1762](https://togithub.com/bazelbuild/bazel-gazelle/pull/1762)
- Fix and expand `reproducible` usage in extensions by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1763](https://togithub.com/bazelbuild/bazel-gazelle/pull/1763)
- Add is_bazel_module to deps.bzl. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771)
- prepare release 0.36 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1752](https://togithub.com/bazelbuild/bazel-gazelle/pull/1752)

#### New Contributors

- [@&#8203;t-8ch](https://togithub.com/t-8ch) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700)
- [@&#8203;dzbarsky](https://togithub.com/dzbarsky) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704)
- [@&#8203;Megakuul](https://togithub.com/Megakuul) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727)
- [@&#8203;fardream](https://togithub.com/fardream) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728)
- [@&#8203;pedrobarco](https://togithub.com/pedrobarco) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743)
- [@&#8203;riking](https://togithub.com/riking) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746)
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750)
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753)
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767)
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.35.0...v0.36.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/bazel-starlib Apr 3, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.35.0` -> `v0.36.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0)

#### What's Changed

- Test with incompatible flags by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1696](https://togithub.com/bazelbuild/bazel-gazelle/pull/1696)
- adding more default gazelle overrides by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1701](https://togithub.com/bazelbuild/bazel-gazelle/pull/1701)
- rule: add accessor for attribute comments by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700)
- rule: set update flag on Rule.AddArg by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1702](https://togithub.com/bazelbuild/bazel-gazelle/pull/1702)
- rule: rename GetAttrComments -> AttrComments by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1703](https://togithub.com/bazelbuild/bazel-gazelle/pull/1703)
- Remove some usage of deprecated ioutil by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704)
- Allow passing Gazelle binary as a file by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1706](https://togithub.com/bazelbuild/bazel-gazelle/pull/1706)
- rule: allow usage of Label struct with Rule APIs by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1705](https://togithub.com/bazelbuild/bazel-gazelle/pull/1705)
- Remove ioutil usage by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1707](https://togithub.com/bazelbuild/bazel-gazelle/pull/1707)
- doc: fix link to Swift gazelle plugin by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1708](https://togithub.com/bazelbuild/bazel-gazelle/pull/1708)
- Fix two shellcheck warnings in gazelle.bash.in by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1710](https://togithub.com/bazelbuild/bazel-gazelle/pull/1710)
- implement expression conversions via BzlExprValue interface by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1714](https://togithub.com/bazelbuild/bazel-gazelle/pull/1714)
- update documentation for 0.35 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1712](https://togithub.com/bazelbuild/bazel-gazelle/pull/1712)
- Update circl to v1.3.7 in tests by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1718](https://togithub.com/bazelbuild/bazel-gazelle/pull/1718)
- rule: make value sorting configurable (alternative implementation) by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1719](https://togithub.com/bazelbuild/bazel-gazelle/pull/1719)
- Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only
repos. by [@&#8203;Megakuul](https://togithub.com/Megakuul) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727)
- Add default gazelle override for github.com/cockroachdb/errors. by
[@&#8203;fardream](https://togithub.com/fardream) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728)
- README: fix resolve_regexp doc by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1729](https://togithub.com/bazelbuild/bazel-gazelle/pull/1729)
- feat(bzlmod): allow `default_gazelle_attributes` for `go_deps`
extension by [@&#8203;tyler-french](https://togithub.com/tyler-french)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1716](https://togithub.com/bazelbuild/bazel-gazelle/pull/1716)
- add new std_packages from go 1.22 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1740](https://togithub.com/bazelbuild/bazel-gazelle/pull/1740)
- fix: wrap generation test labels with Label() by
[@&#8203;pedrobarco](https://togithub.com/pedrobarco) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743)
- proto: Add Bzlmod support for well-known types by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1741](https://togithub.com/bazelbuild/bazel-gazelle/pull/1741)
- Test BCR with Bazel 6.5.0 and 7.0.2 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1744](https://togithub.com/bazelbuild/bazel-gazelle/pull/1744)
- Set go_naming_convention for cel-go by
[@&#8203;riking](https://togithub.com/riking) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746)
- nit: fix error message in go_repository by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750)
- Add `go_deps.config(env = ...)` as a replacement for
`gazelle_dependencies(go_env = ...)` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1748](https://togithub.com/bazelbuild/bazel-gazelle/pull/1748)
- Warn if integrity not specified for archive_override by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753)
- Use host module cache whithout build cache and verify it by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1755](https://togithub.com/bazelbuild/bazel-gazelle/pull/1755)
- Update default_gazelle_overrides.bzl by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1758](https://togithub.com/bazelbuild/bazel-gazelle/pull/1758)
- Mark `go_deps` extension as reproducible by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1761](https://togithub.com/bazelbuild/bazel-gazelle/pull/1761)
- Ignore `purego` build constraint by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767)
- Expose path to root `go.mod` to rules_go by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1762](https://togithub.com/bazelbuild/bazel-gazelle/pull/1762)
- Fix and expand `reproducible` usage in extensions by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1763](https://togithub.com/bazelbuild/bazel-gazelle/pull/1763)
- Add is_bazel_module to deps.bzl. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771)
- prepare release 0.36 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1752](https://togithub.com/bazelbuild/bazel-gazelle/pull/1752)

#### New Contributors

- [@&#8203;t-8ch](https://togithub.com/t-8ch) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700)
- [@&#8203;dzbarsky](https://togithub.com/dzbarsky) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704)
- [@&#8203;Megakuul](https://togithub.com/Megakuul) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727)
- [@&#8203;fardream](https://togithub.com/fardream) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728)
- [@&#8203;pedrobarco](https://togithub.com/pedrobarco) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743)
- [@&#8203;riking](https://togithub.com/riking) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746)
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750)
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753)
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767)
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.35.0...v0.36.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Apr 4, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.35.0` -> `v0.36.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0)

#### What's Changed

- Test with incompatible flags by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1696](https://togithub.com/bazelbuild/bazel-gazelle/pull/1696)
- adding more default gazelle overrides by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1701](https://togithub.com/bazelbuild/bazel-gazelle/pull/1701)
- rule: add accessor for attribute comments by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700)
- rule: set update flag on Rule.AddArg by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1702](https://togithub.com/bazelbuild/bazel-gazelle/pull/1702)
- rule: rename GetAttrComments -> AttrComments by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1703](https://togithub.com/bazelbuild/bazel-gazelle/pull/1703)
- Remove some usage of deprecated ioutil by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704)
- Allow passing Gazelle binary as a file by
[@&#8203;linzhp](https://togithub.com/linzhp) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1706](https://togithub.com/bazelbuild/bazel-gazelle/pull/1706)
- rule: allow usage of Label struct with Rule APIs by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1705](https://togithub.com/bazelbuild/bazel-gazelle/pull/1705)
- Remove ioutil usage by
[@&#8203;dzbarsky](https://togithub.com/dzbarsky) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1707](https://togithub.com/bazelbuild/bazel-gazelle/pull/1707)
- doc: fix link to Swift gazelle plugin by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1708](https://togithub.com/bazelbuild/bazel-gazelle/pull/1708)
- Fix two shellcheck warnings in gazelle.bash.in by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1710](https://togithub.com/bazelbuild/bazel-gazelle/pull/1710)
- implement expression conversions via BzlExprValue interface by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1714](https://togithub.com/bazelbuild/bazel-gazelle/pull/1714)
- update documentation for 0.35 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1712](https://togithub.com/bazelbuild/bazel-gazelle/pull/1712)
- Update circl to v1.3.7 in tests by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1718](https://togithub.com/bazelbuild/bazel-gazelle/pull/1718)
- rule: make value sorting configurable (alternative implementation) by
[@&#8203;t-8ch](https://togithub.com/t-8ch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1719](https://togithub.com/bazelbuild/bazel-gazelle/pull/1719)
- Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only
repos. by [@&#8203;Megakuul](https://togithub.com/Megakuul) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727)
- Add default gazelle override for github.com/cockroachdb/errors. by
[@&#8203;fardream](https://togithub.com/fardream) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728)
- README: fix resolve_regexp doc by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1729](https://togithub.com/bazelbuild/bazel-gazelle/pull/1729)
- feat(bzlmod): allow `default_gazelle_attributes` for `go_deps`
extension by [@&#8203;tyler-french](https://togithub.com/tyler-french)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1716](https://togithub.com/bazelbuild/bazel-gazelle/pull/1716)
- add new std_packages from go 1.22 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1740](https://togithub.com/bazelbuild/bazel-gazelle/pull/1740)
- fix: wrap generation test labels with Label() by
[@&#8203;pedrobarco](https://togithub.com/pedrobarco) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743)
- proto: Add Bzlmod support for well-known types by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1741](https://togithub.com/bazelbuild/bazel-gazelle/pull/1741)
- Test BCR with Bazel 6.5.0 and 7.0.2 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1744](https://togithub.com/bazelbuild/bazel-gazelle/pull/1744)
- Set go_naming_convention for cel-go by
[@&#8203;riking](https://togithub.com/riking) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746)
- nit: fix error message in go_repository by
[@&#8203;hauserx](https://togithub.com/hauserx) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750)
- Add `go_deps.config(env = ...)` as a replacement for
`gazelle_dependencies(go_env = ...)` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1748](https://togithub.com/bazelbuild/bazel-gazelle/pull/1748)
- Warn if integrity not specified for archive_override by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753)
- Use host module cache whithout build cache and verify it by
[@&#8203;scaiper](https://togithub.com/scaiper) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1755](https://togithub.com/bazelbuild/bazel-gazelle/pull/1755)
- Update default_gazelle_overrides.bzl by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1758](https://togithub.com/bazelbuild/bazel-gazelle/pull/1758)
- Mark `go_deps` extension as reproducible by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1761](https://togithub.com/bazelbuild/bazel-gazelle/pull/1761)
- Ignore `purego` build constraint by
[@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767)
- Expose path to root `go.mod` to rules_go by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1762](https://togithub.com/bazelbuild/bazel-gazelle/pull/1762)
- Fix and expand `reproducible` usage in extensions by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1763](https://togithub.com/bazelbuild/bazel-gazelle/pull/1763)
- Add is_bazel_module to deps.bzl. by
[@&#8203;spags-lacework](https://togithub.com/spags-lacework) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771)
- prepare release 0.36 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1752](https://togithub.com/bazelbuild/bazel-gazelle/pull/1752)

#### New Contributors

- [@&#8203;t-8ch](https://togithub.com/t-8ch) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700)
- [@&#8203;dzbarsky](https://togithub.com/dzbarsky) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704)
- [@&#8203;Megakuul](https://togithub.com/Megakuul) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727)
- [@&#8203;fardream](https://togithub.com/fardream) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728)
- [@&#8203;pedrobarco](https://togithub.com/pedrobarco) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743)
- [@&#8203;riking](https://togithub.com/riking) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746)
- [@&#8203;hauserx](https://togithub.com/hauserx) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750)
- [@&#8203;scaiper](https://togithub.com/scaiper) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753)
- [@&#8203;mattyclarkson](https://togithub.com/mattyclarkson) made their
first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767)
- [@&#8203;spags-lacework](https://togithub.com/spags-lacework) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.35.0...v0.36.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants