-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bzlmod): allow default_gazelle_attributes
for go_deps
extension
#1716
Conversation
dcae49a
to
465e22f
Compare
global_overrides
for go_deps
extensiondefault_gazelle_attributes
for go_deps
extension
@fmeum Please do not merge, I have not yet tested this at Uber |
I tested this and it works as expected. |
The one thing I'm worried about is that the new default attributes are override by the per-module defaults provided by Gazelle. This makes adding a new default more breaking. But having it the other way round would remove most of the use of the Gazelle-provided defaults. |
I agree, but I think this implementation provides the most user-friendly approach, given the following considerations:
Two changes that should be added in this PR (which I will add), are:
|
2a56ff4
to
4dec464
Compare
I still think that the way you implemented precedence is the right one: Every module with Gazelle-provided defaults works if you don't specify a default override and if you do, you explicitly give up convenience for flexibility. I think that's fine as long as we restore the list of defaults. |
4cbbf20
to
57a1254
Compare
The PR description is not up-to-date anymore, it still describes the previous precedence rule. |
de1ada8
to
a7ea009
Compare
Good point, updated. |
…ion (bazel-contrib#1716) * allow global overrides * Update internal/bzlmod/go_deps.bzl --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0) #### What's Changed - Test with incompatible flags by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1696](https://togithub.com/bazelbuild/bazel-gazelle/pull/1696) - adding more default gazelle overrides by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1701](https://togithub.com/bazelbuild/bazel-gazelle/pull/1701) - rule: add accessor for attribute comments by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700) - rule: set update flag on Rule.AddArg by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1702](https://togithub.com/bazelbuild/bazel-gazelle/pull/1702) - rule: rename GetAttrComments -> AttrComments by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1703](https://togithub.com/bazelbuild/bazel-gazelle/pull/1703) - Remove some usage of deprecated ioutil by [@​dzbarsky](https://togithub.com/dzbarsky) in [https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704) - Allow passing Gazelle binary as a file by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1706](https://togithub.com/bazelbuild/bazel-gazelle/pull/1706) - rule: allow usage of Label struct with Rule APIs by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1705](https://togithub.com/bazelbuild/bazel-gazelle/pull/1705) - Remove ioutil usage by [@​dzbarsky](https://togithub.com/dzbarsky) in [https://github.com/bazelbuild/bazel-gazelle/pull/1707](https://togithub.com/bazelbuild/bazel-gazelle/pull/1707) - doc: fix link to Swift gazelle plugin by [@​cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1708](https://togithub.com/bazelbuild/bazel-gazelle/pull/1708) - Fix two shellcheck warnings in gazelle.bash.in by [@​mortenmj](https://togithub.com/mortenmj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1710](https://togithub.com/bazelbuild/bazel-gazelle/pull/1710) - implement expression conversions via BzlExprValue interface by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1714](https://togithub.com/bazelbuild/bazel-gazelle/pull/1714) - update documentation for 0.35 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1712](https://togithub.com/bazelbuild/bazel-gazelle/pull/1712) - Update circl to v1.3.7 in tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1718](https://togithub.com/bazelbuild/bazel-gazelle/pull/1718) - rule: make value sorting configurable (alternative implementation) by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1719](https://togithub.com/bazelbuild/bazel-gazelle/pull/1719) - Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only repos. by [@​Megakuul](https://togithub.com/Megakuul) in [https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727) - Add default gazelle override for github.com/cockroachdb/errors. by [@​fardream](https://togithub.com/fardream) in [https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728) - README: fix resolve_regexp doc by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1729](https://togithub.com/bazelbuild/bazel-gazelle/pull/1729) - feat(bzlmod): allow `default_gazelle_attributes` for `go_deps` extension by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1716](https://togithub.com/bazelbuild/bazel-gazelle/pull/1716) - add new std_packages from go 1.22 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1740](https://togithub.com/bazelbuild/bazel-gazelle/pull/1740) - fix: wrap generation test labels with Label() by [@​pedrobarco](https://togithub.com/pedrobarco) in [https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743) - proto: Add Bzlmod support for well-known types by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1741](https://togithub.com/bazelbuild/bazel-gazelle/pull/1741) - Test BCR with Bazel 6.5.0 and 7.0.2 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1744](https://togithub.com/bazelbuild/bazel-gazelle/pull/1744) - Set go_naming_convention for cel-go by [@​riking](https://togithub.com/riking) in [https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746) - nit: fix error message in go_repository by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750) - Add `go_deps.config(env = ...)` as a replacement for `gazelle_dependencies(go_env = ...)` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1748](https://togithub.com/bazelbuild/bazel-gazelle/pull/1748) - Warn if integrity not specified for archive_override by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753) - Use host module cache whithout build cache and verify it by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/bazel-gazelle/pull/1755](https://togithub.com/bazelbuild/bazel-gazelle/pull/1755) - Update default_gazelle_overrides.bzl by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1758](https://togithub.com/bazelbuild/bazel-gazelle/pull/1758) - Mark `go_deps` extension as reproducible by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1761](https://togithub.com/bazelbuild/bazel-gazelle/pull/1761) - Ignore `purego` build constraint by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767) - Expose path to root `go.mod` to rules_go by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1762](https://togithub.com/bazelbuild/bazel-gazelle/pull/1762) - Fix and expand `reproducible` usage in extensions by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1763](https://togithub.com/bazelbuild/bazel-gazelle/pull/1763) - Add is_bazel_module to deps.bzl. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771) - prepare release 0.36 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1752](https://togithub.com/bazelbuild/bazel-gazelle/pull/1752) #### New Contributors - [@​t-8ch](https://togithub.com/t-8ch) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700) - [@​dzbarsky](https://togithub.com/dzbarsky) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704) - [@​Megakuul](https://togithub.com/Megakuul) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727) - [@​fardream](https://togithub.com/fardream) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728) - [@​pedrobarco](https://togithub.com/pedrobarco) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743) - [@​riking](https://togithub.com/riking) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.35.0...v0.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0) #### What's Changed - Test with incompatible flags by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1696](https://togithub.com/bazelbuild/bazel-gazelle/pull/1696) - adding more default gazelle overrides by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1701](https://togithub.com/bazelbuild/bazel-gazelle/pull/1701) - rule: add accessor for attribute comments by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700) - rule: set update flag on Rule.AddArg by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1702](https://togithub.com/bazelbuild/bazel-gazelle/pull/1702) - rule: rename GetAttrComments -> AttrComments by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1703](https://togithub.com/bazelbuild/bazel-gazelle/pull/1703) - Remove some usage of deprecated ioutil by [@​dzbarsky](https://togithub.com/dzbarsky) in [https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704) - Allow passing Gazelle binary as a file by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1706](https://togithub.com/bazelbuild/bazel-gazelle/pull/1706) - rule: allow usage of Label struct with Rule APIs by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1705](https://togithub.com/bazelbuild/bazel-gazelle/pull/1705) - Remove ioutil usage by [@​dzbarsky](https://togithub.com/dzbarsky) in [https://github.com/bazelbuild/bazel-gazelle/pull/1707](https://togithub.com/bazelbuild/bazel-gazelle/pull/1707) - doc: fix link to Swift gazelle plugin by [@​cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1708](https://togithub.com/bazelbuild/bazel-gazelle/pull/1708) - Fix two shellcheck warnings in gazelle.bash.in by [@​mortenmj](https://togithub.com/mortenmj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1710](https://togithub.com/bazelbuild/bazel-gazelle/pull/1710) - implement expression conversions via BzlExprValue interface by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1714](https://togithub.com/bazelbuild/bazel-gazelle/pull/1714) - update documentation for 0.35 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1712](https://togithub.com/bazelbuild/bazel-gazelle/pull/1712) - Update circl to v1.3.7 in tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1718](https://togithub.com/bazelbuild/bazel-gazelle/pull/1718) - rule: make value sorting configurable (alternative implementation) by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1719](https://togithub.com/bazelbuild/bazel-gazelle/pull/1719) - Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only repos. by [@​Megakuul](https://togithub.com/Megakuul) in [https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727) - Add default gazelle override for github.com/cockroachdb/errors. by [@​fardream](https://togithub.com/fardream) in [https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728) - README: fix resolve_regexp doc by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1729](https://togithub.com/bazelbuild/bazel-gazelle/pull/1729) - feat(bzlmod): allow `default_gazelle_attributes` for `go_deps` extension by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1716](https://togithub.com/bazelbuild/bazel-gazelle/pull/1716) - add new std_packages from go 1.22 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1740](https://togithub.com/bazelbuild/bazel-gazelle/pull/1740) - fix: wrap generation test labels with Label() by [@​pedrobarco](https://togithub.com/pedrobarco) in [https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743) - proto: Add Bzlmod support for well-known types by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1741](https://togithub.com/bazelbuild/bazel-gazelle/pull/1741) - Test BCR with Bazel 6.5.0 and 7.0.2 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1744](https://togithub.com/bazelbuild/bazel-gazelle/pull/1744) - Set go_naming_convention for cel-go by [@​riking](https://togithub.com/riking) in [https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746) - nit: fix error message in go_repository by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750) - Add `go_deps.config(env = ...)` as a replacement for `gazelle_dependencies(go_env = ...)` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1748](https://togithub.com/bazelbuild/bazel-gazelle/pull/1748) - Warn if integrity not specified for archive_override by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753) - Use host module cache whithout build cache and verify it by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/bazel-gazelle/pull/1755](https://togithub.com/bazelbuild/bazel-gazelle/pull/1755) - Update default_gazelle_overrides.bzl by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1758](https://togithub.com/bazelbuild/bazel-gazelle/pull/1758) - Mark `go_deps` extension as reproducible by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1761](https://togithub.com/bazelbuild/bazel-gazelle/pull/1761) - Ignore `purego` build constraint by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767) - Expose path to root `go.mod` to rules_go by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1762](https://togithub.com/bazelbuild/bazel-gazelle/pull/1762) - Fix and expand `reproducible` usage in extensions by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1763](https://togithub.com/bazelbuild/bazel-gazelle/pull/1763) - Add is_bazel_module to deps.bzl. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771) - prepare release 0.36 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1752](https://togithub.com/bazelbuild/bazel-gazelle/pull/1752) #### New Contributors - [@​t-8ch](https://togithub.com/t-8ch) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700) - [@​dzbarsky](https://togithub.com/dzbarsky) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704) - [@​Megakuul](https://togithub.com/Megakuul) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727) - [@​fardream](https://togithub.com/fardream) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728) - [@​pedrobarco](https://togithub.com/pedrobarco) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743) - [@​riking](https://togithub.com/riking) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.35.0...v0.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.35.0` -> `v0.36.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.36.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.36.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.35.0...v0.36.0) #### What's Changed - Test with incompatible flags by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1696](https://togithub.com/bazelbuild/bazel-gazelle/pull/1696) - adding more default gazelle overrides by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1701](https://togithub.com/bazelbuild/bazel-gazelle/pull/1701) - rule: add accessor for attribute comments by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700) - rule: set update flag on Rule.AddArg by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1702](https://togithub.com/bazelbuild/bazel-gazelle/pull/1702) - rule: rename GetAttrComments -> AttrComments by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1703](https://togithub.com/bazelbuild/bazel-gazelle/pull/1703) - Remove some usage of deprecated ioutil by [@​dzbarsky](https://togithub.com/dzbarsky) in [https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704) - Allow passing Gazelle binary as a file by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1706](https://togithub.com/bazelbuild/bazel-gazelle/pull/1706) - rule: allow usage of Label struct with Rule APIs by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1705](https://togithub.com/bazelbuild/bazel-gazelle/pull/1705) - Remove ioutil usage by [@​dzbarsky](https://togithub.com/dzbarsky) in [https://github.com/bazelbuild/bazel-gazelle/pull/1707](https://togithub.com/bazelbuild/bazel-gazelle/pull/1707) - doc: fix link to Swift gazelle plugin by [@​cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1708](https://togithub.com/bazelbuild/bazel-gazelle/pull/1708) - Fix two shellcheck warnings in gazelle.bash.in by [@​mortenmj](https://togithub.com/mortenmj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1710](https://togithub.com/bazelbuild/bazel-gazelle/pull/1710) - implement expression conversions via BzlExprValue interface by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1714](https://togithub.com/bazelbuild/bazel-gazelle/pull/1714) - update documentation for 0.35 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1712](https://togithub.com/bazelbuild/bazel-gazelle/pull/1712) - Update circl to v1.3.7 in tests by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1718](https://togithub.com/bazelbuild/bazel-gazelle/pull/1718) - rule: make value sorting configurable (alternative implementation) by [@​t-8ch](https://togithub.com/t-8ch) in [https://github.com/bazelbuild/bazel-gazelle/pull/1719](https://togithub.com/bazelbuild/bazel-gazelle/pull/1719) - Add check in `update-repos` to omit reading `WORKSPACE` on bzlmod only repos. by [@​Megakuul](https://togithub.com/Megakuul) in [https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727) - Add default gazelle override for github.com/cockroachdb/errors. by [@​fardream](https://togithub.com/fardream) in [https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728) - README: fix resolve_regexp doc by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1729](https://togithub.com/bazelbuild/bazel-gazelle/pull/1729) - feat(bzlmod): allow `default_gazelle_attributes` for `go_deps` extension by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1716](https://togithub.com/bazelbuild/bazel-gazelle/pull/1716) - add new std_packages from go 1.22 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1740](https://togithub.com/bazelbuild/bazel-gazelle/pull/1740) - fix: wrap generation test labels with Label() by [@​pedrobarco](https://togithub.com/pedrobarco) in [https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743) - proto: Add Bzlmod support for well-known types by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1741](https://togithub.com/bazelbuild/bazel-gazelle/pull/1741) - Test BCR with Bazel 6.5.0 and 7.0.2 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1744](https://togithub.com/bazelbuild/bazel-gazelle/pull/1744) - Set go_naming_convention for cel-go by [@​riking](https://togithub.com/riking) in [https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746) - nit: fix error message in go_repository by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750) - Add `go_deps.config(env = ...)` as a replacement for `gazelle_dependencies(go_env = ...)` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1748](https://togithub.com/bazelbuild/bazel-gazelle/pull/1748) - Warn if integrity not specified for archive_override by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753) - Use host module cache whithout build cache and verify it by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/bazel-gazelle/pull/1755](https://togithub.com/bazelbuild/bazel-gazelle/pull/1755) - Update default_gazelle_overrides.bzl by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1758](https://togithub.com/bazelbuild/bazel-gazelle/pull/1758) - Mark `go_deps` extension as reproducible by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1761](https://togithub.com/bazelbuild/bazel-gazelle/pull/1761) - Ignore `purego` build constraint by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767) - Expose path to root `go.mod` to rules_go by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1762](https://togithub.com/bazelbuild/bazel-gazelle/pull/1762) - Fix and expand `reproducible` usage in extensions by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1763](https://togithub.com/bazelbuild/bazel-gazelle/pull/1763) - Add is_bazel_module to deps.bzl. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771) - prepare release 0.36 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1752](https://togithub.com/bazelbuild/bazel-gazelle/pull/1752) #### New Contributors - [@​t-8ch](https://togithub.com/t-8ch) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1700](https://togithub.com/bazelbuild/bazel-gazelle/pull/1700) - [@​dzbarsky](https://togithub.com/dzbarsky) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1704](https://togithub.com/bazelbuild/bazel-gazelle/pull/1704) - [@​Megakuul](https://togithub.com/Megakuul) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1727](https://togithub.com/bazelbuild/bazel-gazelle/pull/1727) - [@​fardream](https://togithub.com/fardream) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1728](https://togithub.com/bazelbuild/bazel-gazelle/pull/1728) - [@​pedrobarco](https://togithub.com/pedrobarco) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1743](https://togithub.com/bazelbuild/bazel-gazelle/pull/1743) - [@​riking](https://togithub.com/riking) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1746](https://togithub.com/bazelbuild/bazel-gazelle/pull/1746) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1750](https://togithub.com/bazelbuild/bazel-gazelle/pull/1750) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1753](https://togithub.com/bazelbuild/bazel-gazelle/pull/1753) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1767](https://togithub.com/bazelbuild/bazel-gazelle/pull/1767) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1771](https://togithub.com/bazelbuild/bazel-gazelle/pull/1771) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.35.0...v0.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
This PR creates a new tag class
default_gazelle_attributes
which allow the root module to provide default values for the gazelle attributes used to create thego_deps
repos.This includes the attributes:
"build_file_generation"
,"build_extra_args"
, and"directives"
.Default attributes will be applied to an attribute only if there is no
gazelle_override
value.If
default_gazelle_attributes
is provided, it will override all path-specific overrides created ininternal/bzlmod/default_gazelle_overrides.bzl
, so users may need to reapply these withgazelle_override
s.If a repo has either a
gazelle_override
or there is adefault_gazelle_attributes
, the"build_file_generation"
attribute will be set to"on"
unless explicitly set to a different value. This is because"build_extra_args"
, and"directives"
anticipate build file generation being enabled.If any value is provided for attrs in a
gazelle_override
, it will override (and not append to) any default attributes. Users must re-add any"directives"
that were indefault_gazelle_attributes
Additional refactoring was done to remove duplication of the handling of these attributes.