Skip to content

Commit

Permalink
gazelle_binary: set package name to 'main' in GoLibrary (#625)
Browse files Browse the repository at this point in the history
Necessary to make the go1.13 linker happy.

Corresponding change in go_binary: bazel-contrib/rules_go#2135

Also: upgrade to rules_go 0.19.3
  • Loading branch information
Jay Conrod authored Aug 21, 2019
1 parent a71c434 commit ac6c8b7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
name = "io_bazel_rules_go",
sha256 = "313f2c7a23fecc33023563f082f381a32b9b7254f727a7dd2d6380ccc6dfe09b",
urls = [
"https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/rules_go/releases/download/0.19.0/rules_go-0.19.0.tar.gz",
"https://github.com/bazelbuild/rules_go/releases/download/0.19.0/rules_go-0.19.0.tar.gz",
"https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/rules_go/releases/download/0.19.3/rules_go-0.19.3.tar.gz",
"https://github.com/bazelbuild/rules_go/releases/download/0.19.3/rules_go-0.19.3.tar.gz",
],
sha256 = "9fb16af4d4836c8222142e54c9efa0bb5fc562ffc893ce2abeac3e25daead144",
)

load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
Expand Down
2 changes: 1 addition & 1 deletion internal/gazelle_binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ var languages = []language.Language{{
go.actions.write(langs_file, langs_content)

# Build the gazelle binary.
library = go.new_library(go)
library = go.new_library(go, is_main = True)
attr = struct(
srcs = [struct(files = [langs_file])],
deps = ctx.attr.languages,
Expand Down

0 comments on commit ac6c8b7

Please sign in to comment.