Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add queue name validation #3

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat: Add queue name validation #3

merged 2 commits into from
Oct 10, 2024

Conversation

nimrodkor
Copy link
Contributor

@nimrodkor nimrodkor commented Oct 10, 2024

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Introduce queue name validation in the Pgmq class to ensure names are within length limits and contain only alphanumeric characters and underscores. Update the createQueue method to incorporate this validation. Adjust formatting scripts in package.json and refine integration tests.

TopicDetails
Test Refinement Refine integration tests by removing unnecessary schema deletion in integration.spec.ts.
Modified files (1)
  • test/integration.spec.ts
Latest Contributors(1)
EmailCommitDate
[email protected]chore-add-pr-title-and...October 10, 2024
Script Update Update formatting script names in package.json to improve clarity and consistency.
Modified files (1)
  • package.json
Latest Contributors(1)
EmailCommitDate
[email protected]Initial-commitOctober 10, 2024
Queue Name Validation Implement queue name validation in the Pgmq class to ensure names are within length limits and contain only alphanumeric characters and underscores.
Modified files (1)
  • src/classes/pgmq.ts
Latest Contributors(1)
EmailCommitDate
[email protected]chore-add-pr-title-and...October 10, 2024
This pull request is reviewed by Baz. Join @nimrodkor and the rest of your team on (Baz).

@nimrodkor nimrodkor changed the title chore(main): Add queue name validation feat: Add queue name validation Oct 10, 2024
@nimrodkor nimrodkor merged commit 5421c96 into main Oct 10, 2024
4 checks passed
@nimrodkor nimrodkor deleted the add-name-validation branch October 10, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant