Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify mobile UI #874

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Beautify mobile UI #874

merged 4 commits into from
Jan 7, 2025

Conversation

lowtorola
Copy link
Contributor

  • makes mobile view sizes first-class on the dashboard
  • major rework of our table scheme to enable mobile viewing (chefs kiss)

Resolves #870 🚀

@lowtorola lowtorola requested a review from nour-massri January 5, 2025 09:16
@lowtorola
Copy link
Contributor Author

@nour-massri pls review tyty need to push this 😃

@lowtorola lowtorola force-pushed the mobile-enhancements branch from 7529747 to 4b8b954 Compare January 6, 2025 10:26
@nour-massri
Copy link
Member

liked the table view of the scrimmage on mobile looks way better
but can you modify the showing 1-1/1 to look on the same line maybe, have a look how is it now

image

@nour-massri
Copy link
Member

maybe also a little bit less width to the sidebar(the left bar that contains rating, team, ....) and more width for the other teams content, or any other way that displays the full name of the team
see here:
image

@lowtorola
Copy link
Contributor Author

Oh i did the vertical page count progress on mobile bc it needs all that room when you have miss of tabs

@lowtorola
Copy link
Contributor Author

Less width for headers is definitely doable though

@nour-massri
Copy link
Member

Oh i did the vertical page count progress on mobile bc it needs all that room when you have miss of tabs
make senses, I just inspected with iphone SE screen in a page with multiple tabs it is kinda tricky

@lowtorola lowtorola force-pushed the mobile-enhancements branch from b7448c3 to d26c452 Compare January 7, 2025 11:32
@lowtorola lowtorola merged commit de78bab into main Jan 7, 2025
3 checks passed
@lowtorola lowtorola deleted the mobile-enhancements branch January 7, 2025 11:37
nour-massri pushed a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile UI Enhancements
2 participants