Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More renames for constistency #43

Merged
merged 3 commits into from
Mar 11, 2022
Merged

More renames for constistency #43

merged 3 commits into from
Mar 11, 2022

Conversation

nkakouros
Copy link

No description provided.

@nkakouros
Copy link
Author

I don't see a button to allow edits from maintainers. Feel free to merge as you see fit (if you want to of course).

@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Mar 11, 2022

I don't see a button to allow edits from maintainers.

Maybe that is because your code resides under the nkakouros-forks org but the PR is from your account. It is a bit unfortunate because we don't have a means of signing then unless I sign and push your changes by hand instead of this PR or you pull them back into your repo.

@nkakouros
Copy link
Author

nkakouros commented Mar 11, 2022

OK, I transferred my fork under my user and now see and checked the option to allow edits.

@martin-schulze-vireso martin-schulze-vireso merged commit 166ed1a into bats-core:master Mar 11, 2022
@martin-schulze-vireso
Copy link
Member

Thanks again.

@nkakouros nkakouros deleted the rename branch March 11, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants