Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames assertions for consistency #34

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Renames assertions for consistency #34

merged 1 commit into from
Mar 11, 2022

Conversation

nkakouros
Copy link

One assertion is named (notice the final s):

assert_file_contains

and another (notice the missing s):

assert_file_exist

This is confusing. I suggest that all assertions have a final s where it makes sense. E.g. assert_file_exists.

Since existing project are using the old type without the final s, aliases are created for those old versions.

@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Mar 5, 2022

I think if we want to move forward with this, we should at least not break existing code. We should offer aliases with the old names for backwards compatibility.

Can you add this and rebase onto current master to get the tests green?

@martin-schulze-vireso
Copy link
Member

After closer inspection a saw that you already had aliases in place. I must have scrolled past them. I tried force push a rebased version but your remote denied access. Can you do so yourself or grant access?

@martin-schulze-vireso martin-schulze-vireso merged commit 89a93e2 into bats-core:master Mar 11, 2022
@martin-schulze-vireso
Copy link
Member

Thanks for the PR and your fast response. I had to force the merge as your commit was not signed. Please consider signing your commits if you have a PGP/GnuPG key or allow changes by the maintainers on your future PRs, so we can sign for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants