Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve destructor performance by 97% on very large folders #1829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve destructor performance by 97% on very large folders #1829

wants to merge 1 commit into from
+44 −22

Conversation

n2qz
Copy link
Contributor

@n2qz n2qz commented Nov 27, 2024

  • Use iter_swap/pop_back idiom to improve FolderData::removeChild() performance
  • Re-order deletions to take advantage of iter_swap/pop_back idiom
  • Add FolderData::bulkRemoveChildren() and use it for removal of virtual folders
  • Prevent inefficient unlinking of child files from a folder being destroyed

@n2qz
Improve destructor performance by 97% on very large folders
61b9844 
- Use iter_swap/pop_back idiom to improve FolderData::removeChild()
  performance
- Re-order deletions to take advantage of iter_swap/pop_back idiom
- Add FolderData::bulkRemoveChildren() and use it for removal of
  virtual folders
- Prevent inefficient unlinking of child files from a folder being
  destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@n2qz