Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make benchmarks compile with modern criterion #30

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Make benchmarks compile with modern criterion #30

merged 1 commit into from
Jul 19, 2016

Conversation

RyanGlScott
Copy link
Contributor

I had to do some minor code changes to make things work, including sprinkling whnfIO in various places (since the type of bench changed in criterion-1) and avoiding the use of the b function with mpMask/mask, since there were some type inference issues involving RankNTypes.

Fixes #29.

@basvandijk
Copy link
Owner

Thanks and sorry for the long delay. Released as 0.2.3.7.

@RyanGlScott
Copy link
Contributor Author

Thanks! There's also basvandijk/case-insensitive#21 if you feel like fixing more benchmarks ;)

@basvandijk
Copy link
Owner

Sure, I will probably have some time for it on ZuriHac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants