Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"a or b c" is not a valid expression but does not raise an Exception on parsing #60

Open
pombredanne opened this issue Feb 9, 2017 · 1 comment
Open

"a or b c" is not a valid expression but does not raise an Exception on parsing #60

pombredanne opened this issue Feb 9, 2017 · 1 comment
Labels
bug

Comments

@pombredanne
Copy link
Collaborator

a or b c is not a valid expression but does not raise an Exception on parsing.
Instead we get this: OR(Symbol('a'), Symbol('b'), Symbol('c')) which is incorrect.
@pombredanne pombredanne added the bug label Feb 9, 2017
@pombredanne
Copy link
Collaborator Author

this is a serious error and I am working on it right away!

pombredanne added a commit that referenced this issue Feb 9, 2017
@pombredanne
#60 'a or b c' expression now raise an exception
810357b 
 * add check in BooleanAlgebra.parse to raise a Parse when two bare
   symbols are after each other without any keyword or operation
 * add optional tracing of what happens when the AST is built
   with a TRACE_PARSE top level flag to help with AST parsing
   debugging
 * add corresponding tests and improve ParseError tests to check for
   the error_code in tests

Signed-off-by: Philippe Ombredanne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pombredanne