Update build_wheels.py for aarch64 support #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attached file here fixes an issue using HuggingFace datasets requiring `soundfile` on aarch64. I compiled on this branch (bastibe/aarchh64-build) using `linux_build.sh` on Grace Hopper, which requires aarch64. This generated libsndfile.so which I renamed to libsndfile_aarch64.so to match the others Then, in [this line ](https://github.com/bastibe/python-soundfile/blob/master/build_wheels.py#L6)I added `'aarch64'` and built the whl as suggested `python setup.py bdist_wheel` followed by installing the `whl` with `pip install dist/soundfile-0.12.1-py2.py3-none-manylinux_2_17_aarch64.whl` This file should just be added to the repo along with the others.
|
See also: bastibe/libsndfile-binaries#35 |
|
This needs to be added to python-package.yml as well, in order to compile. |
add aarch64 to architecture
|
Updated |
|
This does not seem to work in the CI. |
|
I learned that apparently aarch64 with armv9 is not supported and armv8 is in beta for the CI pipeline.
|
|
I see. Thank you for the analysis. Do you know the timeline of these changes? Should we just wait for aarch64 to become available, or do we need a different workaround? |
|
No, not aware of the timeline for these changes to be implemented in Github CI runner. Perhaps a workaround would be to build from source of the |
|
If you need this feature, please update the merge request accordingly. Otherwise, I'll close it. |
|
I have manually merged these changes. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached file here fixes an issue using HuggingFace datasets requiring
soundfileon aarch64.I compiled on this branch (bastibe/aarchh64-build) using
linux_build.shon Grace Hopper, which requires aarch64. This generated libsndfile.so which I renamed to libsndfile_aarch64.so to match the othersThen, in this line I added
'aarch64'and built the whl as suggestedpython setup.py bdist_wheelfollowed by installing thewhlwithpip install dist/soundfile-0.12.1-py2.py3-none-manylinux_2_17_aarch64.whlThis file should just be added to the repo along with the others.