refactor: remove unused getters and broken conditional (onecx#79)

Co-authored-by: Bastian Jakobi <[email protected]>
bastianjakobi · Feb 6, 2024 · 247ede4 · 247ede4
1 parent 8b14bf7
commit 247ede4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/libs/portal-integration-angular/src/lib/core/components/data-table/data-table.component.html b/libs/portal-integration-angular/src/lib/core/components/data-table/data-table.component.html
@@ -25,7 +25,7 @@
             <span class="icon-button-header-wrapper">
               <button
                 id="sortButton"
-                *ngIf="column.sortable && sortedObserved"
+                *ngIf="column.sortable"
                 class="pi"
                 [class.pi-sort-alt-slash]="(column?.id === sortColumn && sortDirection === 'NONE') || column?.id !== sortColumn"
                 [class.pi-sort-amount-up]="column?.id === sortColumn && sortDirection === 'ASCENDING'"

diff --git a/libs/portal-integration-angular/src/lib/core/components/data-table/data-table.component.ts b/libs/portal-integration-angular/src/lib/core/components/data-table/data-table.component.ts
@@ -145,12 +145,6 @@ export class DataTableComponent extends DataSortBase implements OnInit {
   currentFilterOptions$: Observable<SelectItem[]> | undefined
   currentSelectedFilters$: Observable<string[]> | undefined
   filterAmounts$: Observable<Record<string, number>> | undefined
-  get sortedObserved(): boolean {
-    return this.injector.get('DataViewComponent', null)?.sorted.observed || this.sorted.observed
-  }
-  get filteredObserved(): boolean {
-    return this.injector.get('DataViewComponent', null)?.filtered.observed || this.filtered.observed
-  }
   get viewTableRowObserved(): boolean {
     const dv = this.injector.get('DataViewComponent', null)
     return dv?.viewItemObserved || dv?.viewItem.observed || this.viewTableRow.observed