Refresh default schema #710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2016 15:55
Tags `types` and `fields` [deprecated in Solr 4.8](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.3.0/solr/CHANGES.txt#L5572). See also other [ref](apache/lucene-solr@5341918). Riak 2.2.0 integrates Solr 4.10.4: * https://github.com/basho/riak/blob/riak-2.2.0/rebar.config#L23 * https://github.com/basho/yokozuna/blob/2.1.7/rebar.config#L19 * https://github.com/basho/yokozuna/blob/2.1.7/tools/grab-solr.sh#L21 Riak 2.0.7 integrates Solr 4.7.0 hence shall not get this change merged: * https://github.com/basho/riak/blob/riak-2.0.7/rebar.config#L25 * https://github.com/basho/yokozuna/blob/94e847b68e33e50e73f0a26592109cf66c08c77e/tools/grab-solr.sh#L21
In 2013, [usage] of `text` field was deleted. In 2014, `text` stopped to be [default] field and [comment] on aim of `text` field was deleted. Hence only the definition of field `text` was left. [usage]: 5ed36bb#diff-a5640d83f118f6b45ab6c388a89507dcL258 [default]: 7e106dc#diff-a54ecf58f2bd4054b393a8c7b4cbc782L540 [comment]: 5d813cc#diff-a5640d83f118f6b45ab6c388a89507dcL26 This change reviews field `text` in the following way: * Comment field definition, alongside commented sample intended usage; * Rename field to `_text_` as apparent upstream [preference]. [preference]: apache/lucene-solr@a4be57c Note: * Is is ok to use wildcard as source i.e. [`<copyField source="*" ...`](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.3.0/solr/server/solr/configsets/data_driven_schema_configs/conf/managed-schema#L128).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried full text search and I ended up reviewing the default schema.
If you want to keep the default schema compatible with Riak 2.0.7 for another while you need to reject this PR as it removes tags.