Update previous hash during event tick + general refactoring #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the previous hash during `yz_events` tick. Otherwise `sync_indexes` will be called on every tick which could be expensive.
Start NumTicks at 1 so that it actually does full check at N seconds rather than N+1.
Add MAYBE macro that conditionally evaluates expression based on another expression. It can be used to reduce lines of code where you would usually use a case expression to match against a boolean. Use the MAYBE macro in event tick to clean up code a bit.
| end). | ||
|
|
||
| -define(MAYBE(Check, Expression), | ||
| ?MAYBE(Check, Expression, ok)). |
|
+1, if you're into this kind of macro thing. Tested and works. |
rzezeski
added a commit
that referenced
this pull request
Feb 19, 2014
Update previous hash during event tick + general refactoring
|
Gah, I mean to link this is issue #306, not 304. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
yz_events:sync_indexesis called on every tick because the previous hash is not being updated. I noticed this when investigating #304.MAYBEmacro for tighter code.This can be verified by using redbug to verify
sync_indexesis called every 60 seconds.