More AAE ports #308
Merged
More AAE ports #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the value of `never` so that hashtrees never expire.
When switching to manual mode make sure to clear any pending exchanges in the queue.
This is a port of riak_kv commit 5c346c347beb7459fe70e53275f958a68633f5fb Before this commit, AAE trees were immediately cleared after reaching their expiration time. However, trees would not be rebuilt until some time in the future depending on rebuild concurrency, lock acquisition, etc. Until rebuilt, AAE exchange was impossible. This commit changes rebuild logic to separate expiration from deletion. Once a tree reaches it's expiration time, it is marked as expired but not cleared. AAE exchange against this tree can still occur. Only after an expired tree is actually scheduled for rebuild, and successfully grabs all necessary locks, is the tree cleared.
Add the ability to easily expire all hashtrees just like they can easily be cleared. This may be useful sometime in production if you don't trust the hashtrees for some reason and is also useful for testing.
Make sure that when trees are expired it does not prevent them from exchanging. The entire purpose of expiration is to provide behavior similar to clear except that exchange can occur up until the point of tree rebuilding.
| _ = [ok = rpc:call(Node, yz_entropy_mgr, expire_trees, []) | ||
| || Node <- Cluster], | ||
|
|
||
| %% The expire is done very cast so just give it a moment |
There was a problem hiding this comment.
very cast. such spelling. wow
|
Forgot to link this to #253. |
| S. | ||
|
|
||
| -spec get_all_locks(build | rehash, pid()) -> boolean(). | ||
| get_all_locks(Type, Pid) -> |
There was a problem hiding this comment.
This is a strangely named function. It's only getting one lock, not all.
There was a problem hiding this comment.
I use this name to match KV AAE. A lot of this code is strange but want to keep it as close to KV as possible until these two systems merge. It makes porting patches easier.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More AAE ports from basho/riak_kv#765.
neverfor value ofanti_entropy_expireto indicatethat trees should never expire automatically (they can still be
expired manually).
manual mode. Active exchanges will be allowed to finish. The reason
for clearing pending exchanges is because manual mode is about
letting the user control what exchanges happen and thus all pending
automatic exchanges should be dropped.
rebuild. Thus when trees expire they are eligible for exchange up
until the moment they are rebuilt. This is a big improvement from
before which would immediately clear (delete) the tree upon
expiration and could mean hours or days of time before that tree
could be exchanged again thus creating a window of no AAE.
yz_entropy_mgr:expire_trees/0. This may be useful in a productionscenario where the trees are no longer trusted but you still want to
be able to exchange before they are rebuilt. It may also be useful
for testing.
are expired but before they are rebuilt.