Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some dialyzer errors in yz_dt_extractor. #255

Merged
merged 1 commit into from
Dec 18, 2013

Conversation

seancribbs
Copy link

Found by @rzezeski in #250.

@ghost ghost assigned hazen Dec 18, 2013
@hazen
Copy link

hazen commented Dec 18, 2013

No sign of the dialyzer errors which were found in #250

102c102
< ==> before (compile)
---
> ==> after (compile)
131,132d130
< yz_dt_extractor.erl:93: The variable Err can never match since previous clauses completely covered the type #state{}
< yz_dt_extractor.erl:99: The call yz_dt_extractor:extract_map(Name::binary()) breaks the contract (field_path_name()) -> fun(({{binary(),module()},term()},state()) -> state())

👍

@seancribbs
Copy link
Author

@javajolt You got your dialyzer woes solved?

@hazen
Copy link

hazen commented Dec 18, 2013

yup

@seancribbs
Copy link
Author

Thanks for the review!

@hazen
Copy link

hazen commented Dec 18, 2013

Thanks for the help!

seancribbs pushed a commit that referenced this pull request Dec 18, 2013
Fix some dialyzer errors in yz_dt_extractor.
@seancribbs seancribbs merged commit 5c8ac83 into develop Dec 18, 2013
@seancribbs seancribbs deleted the bugfix/sdc/dt-extractor-dialyzer branch December 18, 2013 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants