Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yokozuna-2.1.7 maybe merged siblings not passed to get_ops_for_entry_action [JIRA: RIAK-3073] #712

Open
fadushin opened this issue Dec 1, 2016 · 0 comments

Comments

@fadushin
Copy link
Contributor

fadushin commented Dec 1, 2016

During investigation, we found that the merged object (possibly with siblings) is not passed to get_ops_for_entry_action at:

https://github.com/basho/yokozuna/blob/2.1.7/src/yz_solrq_helper.erl#L201

This can result in generation of siblings in Solr if the supplied Riak object has multiple contents.

It turns out that this scenario is tested in the yz_crdt test in the riak_test repo, but the test passes under Riak 2.2.0, which include 2.1.7. This should be fixed, however, in 2.2.1. It does show up as a bug in the back port to the Riak 2.0 branch, so it will be fixed in 2.0.x.

@Basho-JIRA Basho-JIRA changed the title yokozuna-2.1.7 maybe merged siblings not passed to get_ops_for_entry_action yokozuna-2.1.7 maybe merged siblings not passed to get_ops_for_entry_action [JIRA: RIAK-3073] Dec 1, 2016
fadushin added a commit that referenced this issue Dec 1, 2016
…e we don't possibly generate siblings in Solr, especially for CRDTs.

C.f., #712

Fixes back port of yz_crdt test from develop-2.2 branch.
fadushin added a commit that referenced this issue Dec 2, 2016
…e we don't possibly generate siblings in Solr, especially for CRDTs.

C.f., #712

Fixes back port of yz_crdt test from develop-2.2 branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants