feat: new auth and platform endpoints #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiago-webjump
suggested changes
Aug 11, 2024
Daniel-Boll
reviewed
Aug 12, 2024
RikoKami
reviewed
Aug 12, 2024
…t/new-auth-and-stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As explained at the basementdevs/twitch-better-profile#53, now the authentication will be directly with the platform instead just let the person login through the extension.
This PR removes all the old logic related to how the user is handled through the components (which I have no idea if it's good or not) and load the
occupationsdynamically.About the
colorproperties, IMHO it would be better to get through our own settings, so sooner we can add it atsettingsobject a field forhexdefined by @nexturhe4rt that the person can choose.Changes
occupationsdynamicallyCloses basementdevs/twitch-better-profile#53