Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: improve makefile, setup docker compose, and allow config for max workers #6

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

gvieira18
Copy link
Collaborator

Summary

This PR introduces improvements aimed at enhancing the developer experience (DX):

  • Makefile: Improved for better usability with clearer and more understandable commands.
  • Docker Compose Setup: Added to streamline the development environment setup, though the database is not included directly in this setup. Instead, the database configuration is managed by a separate project ws-scylla.
  • Max Workers: Introduced the ability to specify the maximum number of workers. If MAX_WORKERS is not provided, it defaults to using all available cores.
  • Additional Improvements:
    • Added EditorConfig for consistent code formatting.
    • Simplified versioning by removing current_schema, reducing the annoyance of unnecessary updates every time make migrate is run.

Note

A README about how to set up the system is pending and will be done later. This could be expanded to cover other services as well.

@gvieira18 gvieira18 self-assigned this Aug 21, 2024
@gvieira18 gvieira18 changed the title DX: Improve Makefile, Setup Docker Compose, and Allow Config for Max Workers dx: improve makefile, setup docker compose, and allow config for max workers Aug 21, 2024
Copy link
Contributor

@DanielHe4rt DanielHe4rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielHe4rt DanielHe4rt merged commit 8308050 into develop Aug 21, 2024
2 checks passed
@gvieira18 gvieira18 deleted the dx/update-makefile-setup-docker-dev branch August 21, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants