Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is Conversations (Android) a crying emoji? #96

Closed
xgpt opened this issue Feb 14, 2018 · 8 comments
Closed

Why is Conversations (Android) a crying emoji? #96

xgpt opened this issue Feb 14, 2018 · 8 comments
Labels
bug ui

Comments

@xgpt
Copy link

xgpt commented Feb 14, 2018

It appears as though it has appropriate OMEMO support. I am not a technical user, but it would appear that this is out of date.
@bascht
Copy link
Owner

bascht commented Feb 15, 2018

@xgpt good catch. This is an issue with the way I decided to represent the "tracking issue". For any other client it means: They don't even track / decide to implement the OMEMO support. Conversations had OMEMO support from the start on as far as I remember. It should get a distinct, different emoji. 😸

@Echolon
Copy link
Collaborator

Echolon commented Mar 29, 2018

Yes, agreed. I think a nice green tick would do it for all clients which are done.
Makes choice for people more intuitive.

@nogweii
Copy link
Contributor

nogweii commented Apr 3, 2018 •
edited
Loading

With #102, I feel like we should organize what the symbols should represent (and my suggestions in parentheses):

  • A finished, functioning implementation (🎉)
  • Implementation is in progress (✪)
  • No information available (missing the tracker url) (❓)
  • Has decided to not implement OMEMO. (😭)

If there aren't any complaints, I can submit a PR that implements the logic soon.

EDIT: My new PR would be reviving the work @oodbur did in #59.

@bascht
Copy link
Owner

bascht commented Apr 9, 2018

@evaryont sounds great, do you want to go ahead and submit a PR? I've taken the liberty to merge #40 as I don't want to keep rebasing this PR upon every change. 😬

@nogweii
Copy link
Contributor

nogweii commented Apr 9, 2018 via email

@bascht
Copy link
Owner

bascht commented Apr 9, 2018

👍 No hurries.

@nogweii nogweii mentioned this issue Apr 10, 2018
Merged
bascht pushed a commit that referenced this issue Apr 13, 2018
@nogweii @bascht
Move to a more advanced logic for emoji display
5d8f4dc 
Now clients will show 1 of 4 different symbols depending on the
situation:
- OMEMO support is completed
- OMEMO support is in progress
- We don't know what the state is (missing public tracker)
- The client has decided to *not* implement OMEMO (?!?!)

Expands on the completion and declined states in a full sentence in the
client details page.

Adds a Coy.im client file both to record the situation and demonstrate
the new crying logic.

Closes #59, #96, #106, #83.
@bascht
Copy link
Owner

bascht commented Apr 13, 2018

And #103 is merged. Thanks to @evaryont!

@bascht bascht closed this as completed Apr 13, 2018
@bascht
Copy link
Owner

bascht commented Apr 13, 2018

I opened #104 to add some HTML labels to the Emojis, just for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nogweii @bascht @xgpt @Echolon