Extension fails to load in VS Code 1.90.0 #578

reduckted · 2024-06-06T04:11:10Z

VS Code updated to a new Electron version.
https://code.visualstudio.com/updates/v1_90#_electron-29-update

Same problem as these issues:

rotemdan · 2024-06-06T08:49:09Z

The extension host error log shows:

2024-06-06 09:56:29.973 [error] Activating extension ban.spellright failed due to an error:
2024-06-06 09:56:29.973 [error] TypeError: Cannot read properties of null (reading 'Spellchecker')
	at Object.<anonymous> (c:\Users\X\.vscode\extensions\ban.spellright-3.0.124\lib\bindings.js:46:25)
	at o._compile (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:1271)
	at Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
	at Module.load (node:internal/modules/cjs/loader:1098:32)
	at Module._load (node:internal/modules/cjs/loader:945:12)
	at c._load (node:electron/js2c/node_init:2:13672)
	at E._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:176:5901)
	at n._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:30787)
	at t._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:138:33074)
	at Module.require (node:internal/modules/cjs/loader:1122:19)
	at h (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)
	at Object.<anonymous> (c:\Users\X\.vscode\extensions\ban.spellright-3.0.124\src\spellright.js:18:18)
	at o._compile (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:1271)
	at Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
	at Module.load (node:internal/modules/cjs/loader:1098:32)
	at Module._load (node:internal/modules/cjs/loader:945:12)
	at c._load (node:electron/js2c/node_init:2:13672)
	at E._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:176:5901)
	at n._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:30787)
	at t._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:138:33074)
	at Module.require (node:internal/modules/cjs/loader:1122:19)
	at h (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)
	at activate (c:\Users\X\.vscode\extensions\ban.spellright-3.0.124\src\extension.js:19:24)
	at J.kb (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:159:13460)
	at J.jb (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:159:13173)
	at c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:159:11198
	at async a.n (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:143:6361)
	at async a.m (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:143:6324)
	at async a.l (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:143:5781)

bartosz-antosik · 2024-06-06T08:52:47Z

HI! Thanks @reduckted for pointing out that this is a recurring problem once Electron version gets bumped. I am working on update just there are some unexpected problems from the side of Github Actions runners. Will complete it as soon as possible.

nonoash · 2024-06-28T20:16:31Z

Has it been fixed and broke again in the meantime? I see that last release is after the creation of this issue and last update is today.
I just installed the plugin, it's not working and get the same log as @rotemdan, just want to make sure it's not on my end

rotemdan · 2024-06-28T20:30:48Z

I've updated to the new versions (3.0.126, 3.0.128 and 3.0.132) as soon as they were released, and was still getting the same error. I assumed the issue wasn't fixed since it is still open.

Now that I look at the release note for 3.0.126 (6 June) it shows:

Binaries updated for Electron 29.x.

So I'm not sure why it isn't working. My current installed version is showing v3.0.132.

kmactane · 2024-07-09T14:40:04Z

I'm getting the same problem with VS Code 1.91.0 (using Electron 29.4.0) and Spell Right 3.0.132 (the latest).

bartosz-antosik · 2024-07-09T14:44:40Z

Hi! Could you please tell me what OS you have the issue with?

Here is Linux working ok:

rotemdan · 2024-07-09T15:28:53Z

My current VSCode information (Windows 11):

Version: 1.91.0 (user setup)
Commit: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
Date: 2024-07-01T18:52:22.949Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

(v3.0.132 still errors at startup with Cannot read properties of null (reading 'Spellchecker'))

kmactane · 2024-07-09T15:54:31Z

I'm on Windows 10. Here's the VS Code Help > About information:

Version: 1.91.0 (user setup)
Commit: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
Date: 2024-07-01T18:52:22.949Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.19045

reduckted · 2024-07-09T20:45:20Z

@bartosz-antosik See #582

Ben-Voris · 2024-07-11T01:34:25Z

I have the same config as #578 (comment)

And, other than the first frame, which contains the version as part of the file name, the stack trace is the same as #578 (comment)

2024-07-11 01:57:56.306 [error] Activating extension ban.spellright failed due to an error:
2024-07-11 01:57:56.306 [error] TypeError: Cannot read properties of null (reading 'Spellchecker')
	at Object.<anonymous> (c:\Users\X\.vscode\extensions\ban.spellright-3.0.132\lib\bindings.js:45:25)

I don't know from JS or the VS Code API, but the additional logging in #582 seems like a good thing

reduckted · 2024-07-11T02:50:52Z

It might be a Windows-only problem if it works for you, @bartosz-antosik. For me on Windows, the glob call returns no results. #582 fixes that.

OkkeHendriks · 2024-07-12T08:46:06Z

Same issue here and for colleagues, my version info:

Version: 1.91.1 (system setup)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:06:49.809Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.19045

2024-07-12 10:40:41.759 [error] Activating extension ban.spellright failed due to an error:
2024-07-12 10:40:41.760 [error] TypeError: Cannot read properties of null (reading 'Spellchecker')
	at Object.<anonymous> (c:\Users\okkhen\.vscode\extensions\ban.spellright-3.0.132\lib\bindings.js:45:25)

OkkeHendriks · 2024-07-23T13:49:48Z

Seems to be fixed in version 3.0.134.
Other version info remains equal.

rotemdan · 2024-07-23T14:00:21Z

3.0.134 has started working for me on VSCode 1.91.1 (system details as I sent before), though workspace dictionary (spellright.dict) does not seem to work anymore. Adding to it does work, but words in the workspace dictionary are still highlighted in red. The user dictionary does seem to work though.

I don't remember having issues with the workspace dictionary in the past. I am not currently seeing any special errors in the extension log, related to it.

I also tested 3.0.134 on a clean install of latest VSCode insiders (1.92.0-insider) and the extension is not loading:

Version: 1.92.0-insider (user setup)
Commit: 22e3447b4b410dcf8426bf70743c5dd4030d6122
Date: 2024-07-23T05:03:52.385Z
Electron: 30.2.0
ElectronBuildId: 9884022
Chromium: 124.0.6367.243
Node.js: 20.15.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631

Error:

TypeError: Cannot read properties of null (reading 'Spellchecker')

It's probably a good idea to get 1.92.0 to work as well, before it becomes stable.

v4hn · 2024-10-30T17:16:05Z

Same problem on current linux with vscode version:

Version: 1.95.0
Commit: 912bb683695358a54ae0c670461738984cbb5b95
Date: 2024-10-28T20:16:24.561Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Linux x64 6.9.7-amd64

2024-10-30 17:56:57.450 [error] Activating extension ban.spellright failed due to an error:
2024-10-30 17:56:57.450 [error] TypeError: Cannot read properties of null (reading 'Spellchecker')
    at Object.<anonymous> (~/.vscode/extensions/ban.spellright-3.0.136/lib/bindings.js:46:25)
    at Module._compile (node:internal/modules/cjs/loader:1484:14)
...

reduckted mentioned this issue Jun 30, 2024

Bugfix/fix bindings loading #582

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extension fails to load in VS Code 1.90.0 #578

Extension fails to load in VS Code 1.90.0 #578

reduckted commented Jun 6, 2024

rotemdan commented Jun 6, 2024

bartosz-antosik commented Jun 6, 2024

nonoash commented Jun 28, 2024 •

edited

Loading

rotemdan commented Jun 28, 2024 •

edited

Loading

kmactane commented Jul 9, 2024

bartosz-antosik commented Jul 9, 2024

rotemdan commented Jul 9, 2024

kmactane commented Jul 9, 2024

reduckted commented Jul 9, 2024

Ben-Voris commented Jul 11, 2024 •

edited

Loading

reduckted commented Jul 11, 2024

OkkeHendriks commented Jul 12, 2024 •

edited

Loading

OkkeHendriks commented Jul 23, 2024

rotemdan commented Jul 23, 2024 •

edited

Loading

v4hn commented Oct 30, 2024

Extension fails to load in VS Code 1.90.0 #578

Extension fails to load in VS Code 1.90.0 #578

Comments

reduckted commented Jun 6, 2024

rotemdan commented Jun 6, 2024

bartosz-antosik commented Jun 6, 2024

nonoash commented Jun 28, 2024 • edited Loading

rotemdan commented Jun 28, 2024 • edited Loading

kmactane commented Jul 9, 2024

bartosz-antosik commented Jul 9, 2024

rotemdan commented Jul 9, 2024

kmactane commented Jul 9, 2024

reduckted commented Jul 9, 2024

Ben-Voris commented Jul 11, 2024 • edited Loading

reduckted commented Jul 11, 2024

OkkeHendriks commented Jul 12, 2024 • edited Loading

OkkeHendriks commented Jul 23, 2024

rotemdan commented Jul 23, 2024 • edited Loading

v4hn commented Oct 30, 2024

nonoash commented Jun 28, 2024 •

edited

Loading

rotemdan commented Jun 28, 2024 •

edited

Loading

Ben-Voris commented Jul 11, 2024 •

edited

Loading

OkkeHendriks commented Jul 12, 2024 •

edited

Loading

rotemdan commented Jul 23, 2024 •

edited

Loading