-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot select other language than English #106
Comments
Yes, I restarted several times. I have also tried to completely change my system language to Slovak, but nothing helps. I am x64 system with x64 office and x64 VSCode. |
Everything seems to be exactly as here (x64, English UI, etc., etc.). Let me meditate on this. |
Could you please try to install some other language for a test? Any wester from among those listed on my picture? |
I have tried to install German as system language as well as proofing tools for office, but nothing changed. I have also found that French and Spanish proofing tools were also already preinstalled on my system, but I do not see them in VSCode. |
Do I understand correctly that no matter what you have installed you can see only Could you try to set |
Incredible! I will try to prepare for you a test version which will dump some more debug information and as you to install it & pass the input. I see no other way to deal with this. |
I have installed Slovak on a second machine and it did not appear immediately in restarted VSCode. Had a hope to be able to debug the issue but after the reboot it has appeared. Tough case. |
I still cannot see anything that could be wrong with on the Spell Right's part. Could you please do a test for me? I have prepared a version with some small additional debug information printed. Please download: https://drive.google.com/file/d/1Z2narKQ1gW26JxpQ1K83B6lyIpMrTpFe/view?usp=sharing Then install it manually from VSIX file. Then once you start VSCode please show Console of Developer Tools (Help -> Toggle Developer Tools) and there should appear an information for the loaded dictionaries: Could you tell me what information is displayed there (all the lines that have form |
It looks like the underlying layer, a library I am using from the very beginning of the time node-spellchecker |
You may please consider a workaround - there is a way to run the extension using hunspell spell checker instead of system spellchecker. Then you would have to download desired dictionaries like it is described in To do this set environment variable SPELLCHECKER_PREFER_HUNSPELL (Right Click on My Computer -> Properties -> Advanced system settings -> Environment Variables... -> System variables OR User variables for XXX -> New... -> Variable name = SPELLCHECKER_PREFER_HUNSPELL, Variable Value = 1) - of course if you can set these (user rights). Restart VSCode & then the extension should use HUNSPELL spelling API, not Windows native one. |
Last attempt! I have compiled a sample from here it dumps this on my machine: Could you please download it here: https://drive.google.com/file/d/1wwMP2DYb0v0wsotXzi8EIp-p8exT4ljx/view?usp=sharing And then show me what does it dump on your machine? |
Sorry. Default build settings in VS2017. No idea it could result in something like this. Here is built with defaults of Release settings: https://drive.google.com/file/d/1GPtE1nNAtOrS2S46lBq0kWTB5o9MqwZ-/view?usp=sharing |
Here is the result:
From this it seems that your extension is OK but there is something with my system / office installation. |
By the looks of it. Gosh. For the moment I am officially out of ideas. |
Many thanks for the tests anyway. |
Just to let you know... I have found out that languages offered to VS Code are absolutely independent on my office setup. I can even uninstall office completely and uninstall all language packs and proofing tools or I can make fresh install of the Office in SK language and it has no influence. Only languages that are offered are always the same languages that were preinstalled with windows and it doesn't matter whether there is proofing file for these languages or not. Thanks for all your help. This seems to be some specific windows setup issue on my side. I will rather try the hunspell now. |
Thanks for the update. I suppose, but have not been able to confirm this, that Office and Windows 8+ Spelling API are two independent things. Office works on other platforms (e.g. Windows 7) which do not have the Spelling API. Nevertheless I am disappointed about Windows. So far I had one unresolved issue #53 very similar to this. On the other hand there was the issue #23 which proofs that you can use multiple spelling languages on Single Language Windows edition... I don't know how related this is but I have no Office installed. Just OneNote. Don't know whether this counts... ;-) Looks like there is something possibly off course with spelling API. I will close this thread. Shall you have any updates please post them here, maybe we will be able to reopen the issue with some solution. |
Hello @bartosz-antosik and @kubics , I ran into the same issue but found a solution. So:
On my system this behaviour was reproducible, and as a long time (annoyed) Windows user this feels kind of window-ish to me, which means it is probably intended behaviour.
However, I am not sure if this solution can be applied in some way to #53, so I posted it here. But for #194 and #256 this might be the solution too. |
@Magnati You are a genius! Yest all this seems annoying and total mystery to me! |
Thanks! :) It would be good to get at least one confirmation in one of the three issues, but than you could add this hint to Your README.md By the way, apart from the windows-holes-of-unfortune, thank you for this great package! |
Thank you! I will of course add this to README in next iteration! |
I installed Chinese, but it didn't show up. |
@M-orpheus |
@Magnati Hello, how can you check whether the language package support the "General Input" part? |
How do you actually install a language/dictionary in this extension? In my case, not even English is offered. It's just empty when I run |
Not specific to you as I have exactly the same problem with all the same steps reproducible up to this comment. Setting Thanks to hints suggested here, I already had the "Language pack" installed, but what fixed it for me was installing "Basic typing" for the language: After that VSC/SpellRight finally picked up Croatian. |
The solution of @Magnati solved my problem that was very similar. Thanks |
I have installed SpellRight in latest VSCode 1.19.1 on Windows 10 Pro.
I do have Slovak language installed in "Country and region", which is not selected as Windows display language.
I do have also Slovak proofing tools (dictionary) installed in MS Office 2016 and I am using it for proofing.
However, SpellRight is still only offering English language. I have also tried "spellright.language": "sk-SK", user setting, but this did not help as well.
Thanks in advance for any advice.
The text was updated successfully, but these errors were encountered: