23 add redux #39
Merged
23 add redux #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #39 +/- ##
=========================================
+ Coverage 52.38% 60.78% +8.4%
=========================================
Files 7 8 +1
Lines 42 51 +9
Branches 8 10 +2
=========================================
+ Hits 22 31 +9
Misses 12 12
Partials 8 8
Continue to review full report at Codecov.
|
|
Now would be a good time to mention that both of these extension dev tools are super helpful: Redux dev tools - these are particularly awesome if you dip in to the front end at some point check them out boi |
dpopp07
approved these changes
Nov 8, 2017
| import Landing from '../Landing/Landing'; | ||
| import './App.css'; | ||
|
|
||
| // if in development, enable redux dev tools | ||
| const enhancer = | ||
| process.env.NODE_ENV === 'development' |
There was a problem hiding this comment.
We will need to add some config files or somethin later on. good reminder of that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to go with a modified ducks structure for now described in this article.
We can go over more the structure, but it's basically a tighter coupling of the different action types, action creators, and reducers that will control the application's state. Or at least keeping them together in the same files for the most part, rather than having a few different directories. I like the way this seems, but we'll see how it plays out.
Also, while doing this, I ran in to a really weird Jest caching bug that was showing old non-existent files in my coverage reports. I resolved it by following instructions here and manually clearing my Jest cache but hopefully this doesn't happen again 🤞