Use Illuminate\Support\Carbon instead of Carbon\Carbon

[mgrinspan]

Laravel has a wrapper class for Carbon that it uses for model attributes in the $dates array and the created_at and updated_at attributes. This pull request changes all model docblocks to use the wrapper class instead of the base class.

[svenluijten]

Any update on this? 🙂 This was included in Laravel since laravel/framework#19771, would be useful to have in ide-helper as well 😄

[mrextreme]

It still mixes \Illuminate\Support\Carbon and Carbon\Carbon when generating phpdoc blocks for models. Laravel 5.x, 6.x, 7.x, ide helper 2.6.7

 * @property \Illuminate\Support\Carbon|null $start
 * @property \Carbon|null $stop
 * @property \Carbon|null $contract_ends
 * @property \Illuminate\Support\Carbon|null $created_at
 * @property \Illuminate\Support\Carbon|null $updated_at

all these fields are in the protected $dates array

[mfn]

mixes \Illuminate\Support\Carbon and Carbon\Carbon

But your example only has \Carbon? that seems totally off… ?

[mrextreme]

I copy-pasted that from the actual code, while typed in the text above it from head memory. Just deleted that phpdoc block and ran ide-helper:models again, and the output is different again. \Carbon doesn't even exists, it should be \Carbon\Carbon. Just searched the source code at ...myPathTpProject/vendor/barryvdh/laravel-ide-helper, and everywhere i see \Illuminate\Support\Carbon, yet the output randomly produces \Carbon for some fields. Both start and stop are DATE fields ( date nullable default null ), yet they end up having different classes.

 * @property \Illuminate\Support\Carbon|null $start
 * @property \Carbon\Carbon|null $stop
 * @property \Carbon|null $contract_ends

[svenluijten]

This discussion doesn't seem to be related to this issue? Maybe create a new issue so it can be tracked better? :)

[mrextreme]

ok, sure