Feature/erc20 #13
Closed
Feature/erc20 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e6dc9fd.
TODO: `is MerkelTree` and `insert(leaf)`
davidp94
commented
Jun 15, 2018
| miximusTrees[_erc20Address].instantiated = true; | ||
| } | ||
| require(miximusTrees[_erc20Address].ercInstance.transferFrom(msg.sender, address(this), 1)); | ||
| insert(leaf); |
There was a problem hiding this comment.
@barryWhiteHat I don't know how I should modify that in order to have one MerkelTree per miximusTree
There was a problem hiding this comment.
maybe putting the MTree structure into the miximusTree such as
struct MiximusTree {
ERC20 ercInstance;
bool instantiated;
mapping (bytes32 => bool) roots;
mapping (bytes32 => bool) nullifiers;
Mtree mtree;
}
?
There was a problem hiding this comment.
Yes i think that will work.
|
Is it possible to split the proving & merkle code into a separate common library which is used by both the Ether and Token contracts? |
|
@HarryR I am not sure what you mean? Do you mean the reuse the zksnark witness generation for both? Or do you mean remove the |
|
Moved to #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ERC20 support instead of erc.
Contract is available in
Miximus_ERC20.sol