Improve response sstatus code when query return no results

barreiro · Oct 25, 2024 · 9976302 · 9976302
1 parent 08b7300
commit 9976302
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/docs/site/content/en/openapi/openapi.yaml b/docs/site/content/en/openapi/openapi.yaml
@@ -666,6 +666,10 @@ paths:
           description: The run data will be processed asynchronously
           content:
             text/plain: {}
+        "204":
+          description: Data is valid but no run was created
+          content:
+            text/plain: {}
         "400":
           description: Some fields are missing or invalid
           content:

diff --git a/horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/RunService.java b/horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/RunService.java
@@ -222,6 +222,7 @@ Response add(@QueryParam("test") String testNameOrId,
     @APIResponses(value = {
             @APIResponse(responseCode = "200", description = "id of the newly generated run", content = @Content(mediaType = MediaType.APPLICATION_JSON, schema = @Schema(type = SchemaType.INTEGER, implementation = Integer.class), example = "101")),
             @APIResponse(responseCode = "202", description = "The run data will be processed asynchronously", content = @Content(mediaType = MediaType.TEXT_PLAIN)),
+            @APIResponse(responseCode = "204", description = "Data is valid but no run was created", content = @Content(mediaType = MediaType.TEXT_PLAIN)),
             @APIResponse(responseCode = "400", description = "Some fields are missing or invalid", content = @Content(mediaType = MediaType.APPLICATION_JSON))
     })
     @Operation(description = "Upload a new Run")

diff --git a/horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java b/horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java
@@ -502,6 +502,10 @@ Response addRunFromData(String start, String stop, String test,
         if (datastore.uploadType() == Datastore.UploadType.MUILTI
                 && response.payload instanceof ArrayNode) {
 
+            if (response.payload.isEmpty()) {
+                return Response.status(Response.Status.NO_CONTENT).entity("Query returned no results").build();
+            }
+
             //if we return more than 10 results, offload to async queue to process - this might take a LOOONG time
             if (response.payload.size() > 10) {
                 response.payload.forEach(jsonNode -> {