Add 'set' with no name to dump current values. Check for undefined va…

…lues when linking android
barisyild · Oct 6, 2024 · 66b8f88 · 66b8f88
1 parent 5ed5825
commit 66b8f88
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/toolchain/android-toolchain-clang.xml b/toolchain/android-toolchain-clang.xml
@@ -92,6 +92,9 @@
   <flag value ="-shared" />
   <flag value="--target=${ABITRIPLE}${PLATFORM_NUMBER}" />
 
+  <!-- Build time error, not run time -->
+  <flag value="-Wl,--no-undefined" unless="HXCPP_ALLOW_UNDEFINED" />
+
   <flag value ="-static-libstdc++" />
   <!-- This shows the android link line, which may be so long that it breaks the tool
      https://github.com/HaxeFoundation/hxcpp/pull/1091

diff --git a/tools/hxcpp/BuildTool.hx b/tools/hxcpp/BuildTool.hx
@@ -2216,6 +2216,13 @@ class BuildTool
       }
    }
 
+   function dumpDefs()
+   {
+      Sys.println("Defines:");
+      for(k in mDefines.keys())
+         Sys.println('  $k=${mDefines.get(k)}');
+   }
+
    function parseXML(inXML:XmlAccess,inSection:String, forceRelative:Bool)
    {
       for(el in inXML.elements)
@@ -2225,9 +2232,14 @@ class BuildTool
             switch(el.name)
             {
                case "set" :
-                  var name = substitute(el.att.name);
-                  var value = substitute(el.att.value);
-                  mDefines.set(name,value);
+                  if (el.has.name)
+                  {
+                     var name = substitute(el.att.name);
+                     var value = substitute(el.att.value);
+                     mDefines.set(name,value);
+                  }
+                  else
+                     dumpDefs();
                case "unset" :
                   var name = substitute(el.att.name);
                   mDefines.remove(name);