Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot termination exporter - fetch rebalance recommendations #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gjtempleton
Copy link

@gjtempleton gjtempleton commented Sep 23, 2021

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #13
License Apache 2.0

What's in this PR?

  • Adds instance_type label to terminationIndicator and terminationTime metrics to allow tracking of trends by instance type
  • Adds monitoring for rebalance recommendation on instance metadata endpoint to add new metrics for when instances are being recommended for rebalance, includes the instance_id and instance_type labels

Why?

Rebalance recommendations provide potentially significant advance notice of potential spot disruption before the 2-minute notice of a spot termination. Adding the exposure of this metric allows cluster operators to gain advance warning of potentially large scale spot interruptions in their clusters.

The addition of the instance_type label also allows cluster operators to understand if their spot interruptions are clustered on specific instance types, leading to data driven consideration of instance type choices.

Additional context

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@gjtempleton gjtempleton force-pushed the Monitor-Rebalance-Recommendations branch from 99d3a05 to 19cef23 Compare October 5, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally expose new metrics for AWS Spot Rebalance Recommendations
1 participant