Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cadence based implementation of components for the integrated service operator installation #3406

Merged
merged 15 commits into from
Feb 1, 2021

Conversation

lpuskas
Copy link
Member

@lpuskas lpuskas commented Jan 23, 2021

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #3399
License Apache 2.0

What's in this PR?

Cadence based components to facilitate the installation of the integrated service operator

Why?

The integrated service operator needs to be installed on clusters in order for the new version of integrated services to be supported

Additional context

The final approach for triggering the installation process is under discussion

Checklist

  • Implementation tested (with at least one cloud provider)
  • Code meets the Developer Guide
  • OpenAPI and Postman files updated (if needed)
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

To Do

  • test the activities and the workflow, finalize the configuration

@lpuskas lpuskas self-assigned this Jan 23, 2021
Copy link
Contributor

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider using consistent naming and avoid different abbreviations for integrated services.

E.g. ISOperator, IntServiceOperator, IntegratedServiceOperator

I would prefer writing out IntegratedServiceOperator in type and whatever you see fit in variable names.

internal/cluster/clusteradapter/gorm_clusters.go Outdated Show resolved Hide resolved
internal/cmd/config.go Outdated Show resolved Hide resolved
internal/cmd/config.go Outdated Show resolved Hide resolved
internal/cmd/config.go Outdated Show resolved Hide resolved
src/cluster/is_operator_workflow.go Outdated Show resolved Hide resolved
src/cluster/is_operator_workflow.go Outdated Show resolved Hide resolved
@lpuskas lpuskas marked this pull request as ready for review January 27, 2021 16:59
@lpuskas lpuskas merged commit 0c6446d into master Feb 1, 2021
@lpuskas lpuskas deleted the int-svc-install branch February 1, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated Service Operator installer in Pipeline
3 participants