-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cadence based implementation of components for the integrated service operator installation #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepov
reviewed
Jan 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider using consistent naming and avoid different abbreviations for integrated services.
E.g. ISOperator, IntServiceOperator, IntegratedServiceOperator
I would prefer writing out IntegratedServiceOperator in type and whatever you see fit in variable names.
pepov
reviewed
Jan 27, 2021
lpuskas
force-pushed
the
int-svc-install
branch
from
January 27, 2021 10:58
8e0a50a
to
c553e77
Compare
…ce given a clusterID
…ntegrated service operator installation
…rated service operator installation
… vase of integrated services V2
…ser' to integrated services
…o a single cluster
lpuskas
force-pushed
the
int-svc-install
branch
from
January 28, 2021 14:01
1208cb5
to
45118c0
Compare
pepov
approved these changes
Jan 28, 2021
…er setup workflow
colin014
approved these changes
Jan 30, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Cadence based components to facilitate the installation of the integrated service operator
Why?
The integrated service operator needs to be installed on clusters in order for the new version of integrated services to be supported
Additional context
The final approach for triggering the installation process is under discussion
Checklist
To Do