-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding certificate validity duration in Kafka user #980
Adding certificate validity duration in Kafka user #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have to use the validation duration for the k8s CSR object:
koperator/pkg/pki/k8scsrpki/k8scsr_user.go
Line 253 in a64633a
Request: csr, |
Yes one validation is required as we have 2 different combination available. One for cert-manager with 1 hour as minimum duration and another with k8s CSR object with 10 mins as minimum duration. |
92f9550
to
5f6d996
Compare
5f6d996
to
ffb1fab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also extend the existing tests to include the change in this PR?
func TestReconcileUserCertificate(t *testing.T) { |
func TestReconcileUserCertificate(t *testing.T) { |
case banzaiv1alpha1.OperationStatus: | ||
err = errors.NewWithDetails("Cruise Control operation not supported", "name", ccOperationExecution.GetName(), "namespace", ccOperationExecution.GetNamespace(), "operation", ccOperationExecution.CurrentTaskOperation(), "parameters", ccOperationExecution.CurrentTaskParameters()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: these two lines are not related to the PR and they are copied from #974 to make linter not complain the missing case in the switch statement.
Added it. Kindly review it |
3b1dfb6
to
2e5da3b
Compare
Description
This MR is to add duration in Kafka user spec. It allows user to specify validity time for certificate created by cert manager.
It helps the user to create user certificate for longer duration than the default value of cert manager. #964
Type of Change
Checklist