Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update go-cruise-control to v0.4.0 #949

Merged
merged 2 commits into from
Mar 13, 2023
Merged

feat: update go-cruise-control to v0.4.0 #949

merged 2 commits into from
Mar 13, 2023

Conversation

chrisgacsal
Copy link
Contributor

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

  • update go-cruise-control to v0.4.0 and related tests
  • fix setup-envtest install by pinning its version and setting ./bin binary directory to store kubebuilder assets

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline

@chrisgacsal
fix: setup-envtest install
18f7786 
* pin CLI version
* set envtest binary dir local to ./bin
@chrisgacsal
feat: update go-cruise-control to v0.4.0
88065b5 
* update `go-cruise-control` lib to `v0.4.0`
* update related tests
@chrisgacsal chrisgacsal requested a review from a team as a code owner March 12, 2023 08:36
@chrisgacsal chrisgacsal self-assigned this Mar 12, 2023
pregnor
pregnor approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you manually tried the envtest part, because that is nigh-impossible to verify by heart.

LGTM otherwise.

@chrisgacsal chrisgacsal mentioned this pull request Mar 12, 2023
Merged
4 tasks
@chrisgacsal
Copy link
Contributor Author

I assume you manually tried the envtest part, because that is nigh-impossible to verify by heart.

LGTM otherwise.

Yup. I did test the setup-envtest locally.

bartam1
bartam1 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@bartam1 bartam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisgacsal chrisgacsal merged commit ecd5e7d into master Mar 13, 2023
@chrisgacsal chrisgacsal deleted the update-cc-lib branch March 13, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartam1 bartam1 bartam1 approved these changes

@pregnor pregnor pregnor approved these changes

@panyuenlau panyuenlau Awaiting requested review from panyuenlau

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgacsal @pregnor @bartam1