Min and Max validation for KafkaCluster.spec.Brokers.[].Id #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuvesz
approved these changes
Feb 2, 2023
pregnor
approved these changes
Feb 2, 2023
bartam1
pushed a commit
that referenced
this pull request
Feb 17, 2023
* add just kubebuilder validation markers; code generation NOT run * update CRDs via make manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds kubebuilder markers to implement a minimal validation of the
KafkaCluster.spec.Brokers.[].Idfield according to #913.The updates to the CRD are generated with
make manifests.Additional context
I chose the
Maximum+ExclusiveMaximumcombination of settings because65535is a more recognisable number than 65534.