Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade istio to 1.15.0 #862

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Upgrade istio to 1.15.0 #862

merged 6 commits into from
Sep 16, 2022

Conversation

nishantapatil3
Copy link
Contributor

@nishantapatil3 nishantapatil3 commented Sep 14, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Upgrade istio-1.13 to istio-1.15

Why?

To support the latest istio-1.15 on koperator

Additional context

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

Tests

=== RUN   TestControllers
Running Suite: Controller Suite
===============================
Random Seed: 1663175832
Will run 16 of 16 specs

W0914 10:17:16.363165   68666 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
W0914 10:17:16.365761   68666 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
••••••••••••••••
Ran 16 of 16 Specs in 81.320 seconds
SUCCESS! -- 16 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestControllers (81.32s)
PASS
coverage: [no statements]
ok  	github.com/banzaicloud/koperator/controllers/tests	83.327s	coverage: [no statements]
=== RUN   TestControllersWithClusterRegistry
Running Suite: Controller Suite with Cluster Registry
=====================================================
Random Seed: 1663175832
Will run 8 of 8 specs

W0914 10:17:16.423725   68665 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
W0914 10:17:16.425770   68665 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
••••••••
Ran 8 of 8 Specs in 66.528 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped

@nishantapatil3 nishantapatil3 requested a review from a team as a code owner September 14, 2022 17:16
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2022

CLA assistant check
All committers have signed the CLA.

@nishantapatil3 nishantapatil3 changed the title Upgrade istio115 Upgrade istio to 1.15.0 Sep 14, 2022
Copy link
Member

@panyuenlau panyuenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am curious if this has been tested with a kafka cluster that is accessible from outside of the Kubernetes cluster via external listener using Istio ingress?

See this docs regarding how the external listeners can be created for testing

Note: the external listener part is not covered with the current tests that we have

Copy link
Contributor

@bartam1 bartam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I forgot to put length check in the test. I have fixed it.

Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pregnor
Copy link
Member

pregnor commented Sep 15, 2022

Please wait for either @panyuenlau or @hi-im-aren 's approval as well to have proper +2.

@nishantapatil3
Copy link
Contributor Author

nishantapatil3 commented Sep 15, 2022

Thanks @panyuenlau @hong6914 , for helping me and testing external listeners using istioingress v1.15.0, PASS!

kcat -b a281d7351225e4546a0d2b5289a94f3e-1977502687.us-west-2.elb.amazonaws.com:29092 -t kafkacat-topic -X enable.ssl.certificate.verification=false -L -v
Metadata for kafkacat-topic (from broker -1: a281d7351225e4546a0d2b5289a94f3e-1977502687.us-west-2.elb.amazonaws.com:29092/bootstrap):
 3 brokers:
  broker 0 at a281d7351225e4546a0d2b5289a94f3e-1977502687.us-west-2.elb.amazonaws.com:19095
  broker 2 at a281d7351225e4546a0d2b5289a94f3e-1977502687.us-west-2.elb.amazonaws.com:19097
  broker 1 at a281d7351225e4546a0d2b5289a94f3e-1977502687.us-west-2.elb.amazonaws.com:19096 (controller)
 1 topics:
  topic "kafkacat-topic" with 1 partitions:
    partition 0, leader 0, replicas: 0, isrs: 0 

@nishantapatil3 nishantapatil3 merged commit e86aa4c into master Sep 16, 2022
@nishantapatil3 nishantapatil3 deleted the upgrade_istio115 branch September 16, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants