-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade istio to 1.15.0 #862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I am curious if this has been tested with a kafka cluster that is accessible from outside of the Kubernetes cluster via external listener using Istio ingress?
See this docs regarding how the external listeners can be created for testing
Note: the external listener part is not covered with the current tests that we have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I forgot to put length check in the test. I have fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please wait for either @panyuenlau or @hi-im-aren 's approval as well to have proper +2. |
Thanks @panyuenlau @hong6914 , for helping me and testing external listeners using istioingress v1.15.0, PASS!
|
What's in this PR?
Upgrade istio-1.13 to istio-1.15
Why?
To support the latest istio-1.15 on koperator
Additional context
Checklist
Tests