Fix CN length limitation issue while using cert-manager #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyuenlau
changed the title
hi-im-aren
reviewed
Jun 13, 2022
pregnor
previously approved these changes
Jun 14, 2022
stoader
requested changes
Jun 14, 2022
pregnor
previously approved these changes
Jun 15, 2022
stoader
reviewed
Jun 15, 2022
stoader
previously approved these changes
Jun 15, 2022
Kuvesz
approved these changes
Jun 15, 2022
stoader
approved these changes
Jun 15, 2022
pregnor
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Hash and limit the length of the generated CN for the controller if it exceeds the maximum supported length - 64 characters, reference: https://docs.digicert.com/manage-certificates/public-certificates-data-entries-that/#64character-maximum-limit-violation
Additional context
Tested with cert-manager (as well as csr-operator) using the same Kafka name and namespace as reported in #445
Checklist
TODO
{"level":"info","ts":"2022-06-15T05:01:57.596Z","logger":"controller.KafkaCluster","msg":"A new resource was not found or may not be ready","reconciler group":"kafka.banzaicloud.io","reconciler kind":"KafkaCluster","name":"kafka-pushdelivery-stage-controller","namespace":"pushdelivery-stage","error":"checking secret data fields: SSL JKS certificate has not generated properly yet into secret: kafka-pushdelivery-stage-controller-server-certificate"}