Fix ClusterRole & ClusterRoleBinding hotreload

[vigohe]

Q	A
Bug fix?	yes
New feature?	yes
API breaks?	no
Deprecations?	no
Related tickets	fixes #91
License	Apache 2.0

What's in this PR?

fixes #91 and deletes ClusterRoles when CustomGroup name is not present at the config

Why?

• Hot Reload is not working as intended
• When a CustomGroup it's deleted it should also delete the related ClusterRole and ClusterRoleBinding or RoleBinding

Checklist

• Code meets the Developer Guide
• User guide and development docs updated (if needed)
• Related Helm chart(s) updated (if needed)

[pbalogh-sa]

@vigohe Thanks for contributions. I will check it soon.

[vigohe]

@vigohe Thanks for contributions. I will check it soon.

Nice!

Do you know a better way to delete as cascade all resources related to a ClusterRole, because the only way I found, was to label each resource ( ClusterRoleBinding & RoleBinding ) with the label crole. Then search by the label and delete them.

[pbalogh-sa]

@vigohe I think you can set the ownerreference of rolebindings to the proper role or clusterrole. In this case when you delete the clusterrole or role, the rolebindings will be deleted. This doesn't work in the case of clusterscope resources if the K8s version is 1.21 or above.

[pbalogh-sa]

@vigohe Using labels works in the case of cluster-scoped resources as well (for example clusterrolebindings). I think it's an universal solution . Thanks.
Please resolve conflicts otherwise LGTM.

[pbalogh-sa]

Please resolve conflicts otherwise LGTM.

[vigohe]

Please resolve conflicts otherwise LGTM.

Please resolve conflicts otherwise LGTM.

Did I fix it ?

[pbalogh-sa]

@vigohe Some conflicts are found. Please resolve them.

[vigohe]

@vigohe Some conflicts are found. Please resolve them.

Don't see any conflicts

[pbalogh-sa]

@vigohe . I can squash and merge instead of rebasing.