Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run shellcheck on ci #460

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Run shellcheck on ci #460

merged 2 commits into from
Jun 29, 2020

Conversation

khernyo
Copy link
Contributor

@khernyo khernyo commented Jun 29, 2020

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Run more checks on CI

Additional context

Based on #459, so it should only be merged after that one.

khernyo added 2 commits June 29, 2020 15:54
It's no use to run tests or linters when code generation fails.
@khernyo khernyo force-pushed the run-shellcheck-on-ci branch from 1c61646 to 27d2017 Compare June 29, 2020 13:54
@khernyo khernyo marked this pull request as ready for review June 29, 2020 13:55
@khernyo khernyo requested review from Laci21 and waynz0r June 29, 2020 13:57
@khernyo khernyo merged commit 81544d4 into release-1.6 Jun 29, 2020
@khernyo khernyo deleted the run-shellcheck-on-ci branch June 29, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants