Feature auto link #204
Merged
Feature auto link #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepta
approved these changes
Jun 7, 2021
| } | ||
| const [_, leadingSpace, text, scheme] = match; | ||
| // If no scheme, use default scheme http:// | ||
| const href = scheme ? text : `http://${text}`; |
There was a problem hiding this comment.
Should we make it default to https?
There was a problem hiding this comment.
There are quite some website that are http only (e.g. corporate-internal websites). And for most https sites they would redirect http requests to https anyway.
lucywang000
force-pushed
the
feature-auto-link
branch
from
4e267e6 to
ddf4670
Compare
|
@kepta I just updated the tld regexp, also handled a corner case (see the last commit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #186